[SPARK-44876][PYTHON][FOLLOWUP][3.5] Fix Arrow-optimized Python UDF to delay wrapping the function with fail_on_stopiteration #42785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il_on_stopiteration.
zhengruifeng
approved these changes
Sep 4, 2023
zhengruifeng
pushed a commit
that referenced
this pull request
Sep 4, 2023
…o delay wrapping the function with fail_on_stopiteration ### What changes were proposed in this pull request? This is a backport of #42784. Fixes Arrow-optimized Python UDF to delay wrapping the function with `fail_on_stopiteration`. Also removed unnecessary verification `verify_result_type`. ### Why are the changes needed? For Arrow-optimized Python UDF, `fail_on_stopiteration` can be applied to only the wrapped function to avoid unnecessary overhead. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added the related test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42785 from ueshin/issues/SPARK-44876/3.5/fail_on_stopiteration. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Contributor
|
merged to branch-3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a backport of #42784.
Fixes Arrow-optimized Python UDF to delay wrapping the function with
fail_on_stopiteration.Also removed unnecessary verification
verify_result_type.Why are the changes needed?
For Arrow-optimized Python UDF,
fail_on_stopiterationcan be applied to only the wrapped function to avoid unnecessary overhead.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added the related test.
Was this patch authored or co-authored using generative AI tooling?
No.