Skip to content

[SPARK-44127][R][TESTS] Reenable test_sparkSQL_arrow.R in Java 21 #42644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-44127][R][TESTS] Reenable test_sparkSQL_arrow.R in Java 21 #42644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions R/pkg/tests/fulltests/test_sparkSQL_arrow.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ sparkSession <- sparkR.session(

test_that("createDataFrame/collect Arrow optimization", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))

conf <- callJMethod(sparkSession, "conf")
arrowEnabled <- sparkR.conf("spark.sql.execution.arrow.sparkr.enabled")[[1]]
Expand All @@ -45,16 +43,12 @@ test_that("createDataFrame/collect Arrow optimization", {

test_that("createDataFrame/collect Arrow optimization - many partitions (partition order test)", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
expect_equal(collect(createDataFrame(mtcars, numPartitions = 32)),
collect(createDataFrame(mtcars, numPartitions = 1)))
})

test_that("createDataFrame/collect Arrow optimization - type specification", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
rdf <- data.frame(list(list(a = 1,
b = "a",
c = TRUE,
Expand All @@ -79,8 +73,6 @@ test_that("createDataFrame/collect Arrow optimization - type specification", {

test_that("dapply() Arrow optimization", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
df <- createDataFrame(mtcars)

conf <- callJMethod(sparkSession, "conf")
Expand Down Expand Up @@ -115,8 +107,6 @@ test_that("dapply() Arrow optimization", {

test_that("dapply() Arrow optimization - type specification", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
# Note that regular dapply() seems not supporting date and timestamps
# whereas Arrow-optimized dapply() does.
rdf <- data.frame(list(list(a = 1,
Expand Down Expand Up @@ -146,8 +136,6 @@ test_that("dapply() Arrow optimization - type specification", {

test_that("dapply() Arrow optimization - type specification (date and timestamp)", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
rdf <- data.frame(list(list(a = as.Date("1990-02-24"),
b = as.POSIXct("1990-02-24 12:34:56"))))
df <- createDataFrame(rdf)
Expand All @@ -157,8 +145,6 @@ test_that("dapply() Arrow optimization - type specification (date and timestamp)

test_that("gapply() Arrow optimization", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
df <- createDataFrame(mtcars)

conf <- callJMethod(sparkSession, "conf")
Expand Down Expand Up @@ -202,8 +188,6 @@ test_that("gapply() Arrow optimization", {

test_that("gapply() Arrow optimization - type specification", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
# Note that regular gapply() seems not supporting date and timestamps
# whereas Arrow-optimized gapply() does.
rdf <- data.frame(list(list(a = 1,
Expand Down Expand Up @@ -236,8 +220,6 @@ test_that("gapply() Arrow optimization - type specification", {

test_that("gapply() Arrow optimization - type specification (date and timestamp)", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
rdf <- data.frame(list(list(a = as.Date("1990-02-24"),
b = as.POSIXct("1990-02-24 12:34:56"))))
df <- createDataFrame(rdf)
Expand All @@ -249,8 +231,6 @@ test_that("gapply() Arrow optimization - type specification (date and timestamp)

test_that("Arrow optimization - unsupported types", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))

expect_error(checkSchemaInArrow(structType("a FLOAT")), "not support float type")
expect_error(checkSchemaInArrow(structType("a BINARY")), "not support binary type")
Expand All @@ -262,8 +242,6 @@ test_that("Arrow optimization - unsupported types", {

test_that("SPARK-32478: gapply() Arrow optimization - error message for schema mismatch", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))
df <- createDataFrame(list(list(a = 1L, b = "a")))

expect_error(
Expand All @@ -273,8 +251,6 @@ test_that("SPARK-32478: gapply() Arrow optimization - error message for schema m

test_that("SPARK-43789: Automatically pick the number of partitions based on Arrow batch size", {
skip_if_not_installed("arrow")
# TODO(SPARK-44127) Reenable test_sparkSQL_arrow.R in Java 21
skip_if(sparkR.callJStatic("org.apache.spark.util.Utils", "isJavaVersionAtLeast21"))

conf <- callJMethod(sparkSession, "conf")
maxRecordsPerBatch <- sparkR.conf("spark.sql.execution.arrow.maxRecordsPerBatch")[[1]]
Expand Down