[SPARK-44863][UI] Add a button to download thread dump as a txt in Spark UI #42575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
|
also @sarutak and @jasonli-db |
pan3793
reviewed
Aug 21, 2023
| <div style="display: flex; align-items: center;"> | ||
| <a class="expandbutton" onClick="expandAllThreadStackTrace(true)">Expand All</a> | ||
| <a class="expandbutton d-none" onClick="collapseAllThreadStackTrace(true)">Collapse All</a> | ||
| <a class="downloadbutton" href={"data:text/plain;charset=utf-8," + threadDump.map(_.toString).mkString} download={"threaddump_" + executorId + ".txt"}>Download</a> |
Member
There was a problem hiding this comment.
how about adding "application id" as part of the file name?
Member
Author
There was a problem hiding this comment.
When it comes to distinguishing files, there are several options such as using app id, attempt id, timestamps, executor details, and more to name the files. However, I prefer to keep it simple to allow for easy renaming when users click the button.
yaooqinn
changed the title
LuciferYang
reviewed
Aug 21, 2023
LuciferYang
reviewed
Aug 21, 2023
| */ | ||
| override def toString: String = { | ||
| val sb = new StringBuilder() | ||
| val basic = "\"" + threadName + "\" Id=" + threadId + " " + threadState |
Contributor
There was a problem hiding this comment.
val basic = s""""$threadName" Id=$threadId $threadState"""
sb.append(basic)
or
sb.append("\"").append(threadName).append("\" Id=").append(threadId).append(" ").append(threadState)
// sb.append("\"", threadName, "\" Id=", threadId, " ", threadState) multiple parameters api needs to wait until only Scala 2.13+ is supported.
The former has better readability, while the latter can avoid creating the intermediate string basic.
Member
Author
There was a problem hiding this comment.
I choose another simple way val sb = new StringBuilder(s""""$threadName" Id=$threadId $threadState""")
Contributor
|
cc @jasonli-db and @gengliangwang would you mind take a look? |
zhengruifeng
approved these changes
Aug 24, 2023
Member
Author
|
thank you all, merged to master |
Contributor
|
@yaooqinn thank you so much for working on this! |
Mrhs121
pushed a commit
to Mrhs121/spark
that referenced
this pull request
Jan 2, 2024
…ark UI ### What changes were proposed in this pull request? This PR added a button to download thread dump as a txt w.r.t. jstack formatting ### Why are the changes needed? The formatting of raw jstack can be relatively easy to read and analyze using various thread tools. ### Does this PR introduce _any_ user-facing change?  ### How was this patch tested? #### Raw Dump File [driver.txt](https://github.com/apache/spark/files/12388302/driver.txt) #### Reporting by external tools https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjMvMDgvMjAvZHJpdmVyLnR4dC0tMTMtNTMtMjI=& ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#42575 from yaooqinn/SPARK-44863. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit f7a0b3a)
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Nov 7, 2024
### What changes were proposed in this pull request? Improve `ThreadStackTrace` with `synchronizers`, `monitors`, `lockName`, `lockOwnerName`, `suspended`, `inNative` for thread dump. ### Why are the changes needed? ThreadStackTrace does not support stack trace including `synchronizers`, `monitors`, `lockName`, `lockOwnerName`, `suspended`, `inNative` at present. It's recommend to improve `ThreadStackTrace` of thread dump for more details of thread stack trace. ### Does this PR introduce _any_ user-facing change? The response of `ThreadStack` in `/api/v1/thread_dump` adds `synchronizers`, `monitors`, `lockName`, `lockOwnerName`, `suspended`, `inNative` fields. Cherry pick: - apache/spark#42575 - apache/spark#43095 ### How was this patch tested? `ApiV1BaseResourceSuite#thread_dump` Closes #2888 from SteNicholas/CELEBORN-1697. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR added a button to download thread dump as a txt w.r.t. jstack formatting
Why are the changes needed?
The formatting of raw jstack can be relatively easy to read and analyze using various thread tools.
Does this PR introduce any user-facing change?
How was this patch tested?
Raw Dump File
driver.txt
Reporting by external tools
https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjMvMDgvMjAvZHJpdmVyLnR4dC0tMTMtNTMtMjI=&
Was this patch authored or co-authored using generative AI tooling?
no