[SPARK-44433][PYTHON][CONNECT][SS][FOLLOWUP]Set back USE_DAEMON after creating streaming python processes #42341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WweiL
changed the title
Contributor
Author
|
cc @ueshin Can you take a look? Thank you so much! This doesn't need to goto 3.5. The change was added with the back port PR: https://github.com/apache/spark/pull/42340/files |
ueshin
reviewed
Aug 4, 2023
Comment on lines
109
to
115
| val prevConf = conf.get(PYTHON_USE_DAEMON) | ||
| conf.set(PYTHON_USE_DAEMON, false) | ||
| try { | ||
| SparkEnv.get.destroyPythonWorker(pythonExec, workerModule, envVars.asScala.toMap, worker) | ||
| } finally { | ||
| conf.set(PYTHON_USE_DAEMON, prevConf) | ||
| } |
Member
There was a problem hiding this comment.
I don't think this change is needed as env.destroyPythonWorker won't refer conf.
Member
|
Thanks! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of this comment: #42283 (comment)
Change back the spark conf after creating streaming python process.
Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
Config only change