[SPARK-44631][CONNECT][CORE] Remove session-based directory when the isolated session cache is evicted #42289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @vicennial and @hvanhovell mind taking a look please? |
zhengruifeng
approved these changes
Aug 2, 2023
Member
Author
|
Merged to master and branch-3.5. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 2, 2023
…isolated session cache is evicted ### What changes were proposed in this pull request? This PR proposes to remove session-based directories when the isolated session is evicted from the cache. ### Why are the changes needed? SPARK-44078 added the cache for isolated sessions, and SPARK-44348 added the session-based directory for isolation. When the isolated session cache is evicted, we should remove the session-based directory so it doesn't fail when the same session is used, see also #41625 (comment) ### Does this PR introduce _any_ user-facing change? No to end users since the feature has not been released yet. ### How was this patch tested? I manually tested as described in #41292. Especially, I reduced the TTL to few minutes, and tested as below at the last step: ```python spark.range(10).select(plug_one("id")).show() spark.range(10).select(plug_one("id")).show() # Wait few minutes spark.range(10).select(plug_one("id")).show() ``` I verified that the same session can be added back to the cache, and creates the directory with the same name by reading executor's stderr at Spark UI. Closes #42289 from HyukjinKwon/SPARK-44631. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 35d4765) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to remove session-based directories when the isolated session is evicted from the cache.
Why are the changes needed?
SPARK-44078 added the cache for isolated sessions, and SPARK-44348 added the session-based directory for isolation.
When the isolated session cache is evicted, we should remove the session-based directory so it doesn't fail when the same session is used, see also #41625 (comment)
Does this PR introduce any user-facing change?
No to end users since the feature has not been released yet.
How was this patch tested?
I manually tested as described in #41292. Especially, I reduced the TTL to few minutes, and tested as below at the last step:
I verified that the same session can be added back to the cache, and creates the directory with the same name by reading executor's stderr at Spark UI.