[SPARK-44577][SQL] Fix INSERT BY NAME returns nonsensical error message #42220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Jul 31, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jul 31, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Show resolved
Hide resolved
Contributor
|
can we update the PR description for the new changes? |
Member
Author
Done |
Contributor
For by-name insert, shall we just say "incompatible data columns"? The number of columns does match here. |
Member
Author
Oh, let me align v1 and v2 errors. |
MaxGekk
reviewed
Aug 7, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@MaxGekk does this PR align with your plan of unifying the assignment errors? |
Member
|
@cloud-fan In my PR #42393, I am going to touch non- |
Member
Author
|
Hi @cloud-fan @MaxGekk Shall we continue push on this PR? Thanks. |
cloud-fan
reviewed
Aug 17, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Aug 18, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Aug 31, 2023
cloud-fan
reviewed
Aug 31, 2023
| }, | ||
| "EXTRA_FIELDS" : { | ||
| "message" : [ | ||
| "Cannot write extra fields <colName>." |
Contributor
There was a problem hiding this comment.
it's one column or multiple columns?
Member
Author
There was a problem hiding this comment.
multiple columns, so I do some change, please check it again. Thanks.
cloud-fan
approved these changes
Aug 31, 2023
Contributor
|
thanks, merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 1, 2023
### What changes were proposed in this pull request? Fix INSERT BY NAME returns nonsensical error message on v1 datasource. eg: ```scala CREATE TABLE bug(c1 INT); INSERT INTO bug BY NAME SELECT 1 AS c2; ==> Multi-part identifier cannot be empty. ``` After PR: ```scala [INCOMPATIBLE_DATA_FOR_TABLE.CANNOT_FIND_DATA] Cannot write incompatible data for the table `spark_catalog`.`default`.`bug`: Cannot find data for the output column `c1`. ``` Also fixed the same issue when throwing other INCOMPATIBLE_DATA_FOR_TABLE type errors ### Why are the changes needed? Fix the error msg nonsensical. ### Does this PR introduce _any_ user-facing change? Yes, the error msg in v1 insert by name will be changed. ### How was this patch tested? add new test. Closes #42220 from Hisoka-X/SPARK-44577_insert_by_name_bug_fix. Authored-by: Jia Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 00f6699) Signed-off-by: Wenchen Fan <[email protected]>
Member
Author
|
Thanks @cloud-fan and @MaxGekk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix INSERT BY NAME returns nonsensical error message on v1 datasource.
eg:
After PR:
Also fixed the same issue when throwing other INCOMPATIBLE_DATA_FOR_TABLE type errors
Why are the changes needed?
Fix the error msg nonsensical.
Does this PR introduce any user-facing change?
Yes, the error msg in v1 insert by name will be changed.
How was this patch tested?
add new test.