-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-44247][BUILD] Upgrade Arrow to 13.0.0 #42181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We need upgrade arrow 13.0 and netty 4.1.94+ together |
|
cc @dongjoon-hyun seems arrow 13.0.0 released, we can re-enable arrow-based test case after this one for Java 21 :) |
|
@panbingkun It appears it hasn’t been published to the Maven Central Repository yet. We can testing it using asf-staging first :) |
Thanks @LuciferYang , let's test it in advance. 😄 |
|
|
Let's hold it first because when I wrote this PR, Netty had already released version 4.1.96.Final |
|
@panbingkun Only upgrade arrow to 13.0.0, the netty version is 4.1.93.Final, the test failed will like I think we can supplement this section in the pr description.
then, we can say that both dependencies must be upgraded simultaneously |
Done. |
|
@panbingkun if arrow 13.0.0 is target to support Netty 4.1.96, then it is no longer coupled with the upgrade of Arrow. Can you create a separate PR to upgrade Netty to 4.1.96 first? |
Okay, let me do it. |
|
Last week, I submitted a PR(apache/arrow#36926) on netty arrow memory to make |
|
Thank you for working on this, @panbingkun and @LuciferYang . |
|
BTW, I updated the PR title with SPARK-44247 instead of SPARK-44563. |
|
Yes, arrow |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this PR ready, @panbingkun ?
Done. |
|
Thank you so much, @panbingkun . |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs)
LuciferYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This doesn't need to be merged into 3.5, right? @dongjoon-hyun |
|
Yes, it's too late for Apache Spark 3.5.0. |
OK |
|
The affected version of SPARK-44247 (this PR) is 4.0.0. |
|
All tests passed. |
|
Merged to master for Apache Spark 4. |
### What changes were proposed in this pull request? This PR aims to re-enable `test_sparkSQL_arrow.R` in Java 21. This depends on #42181 . ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ java -version openjdk version "21" 2023-09-19 OpenJDK Runtime Environment (build 21+35-2513) OpenJDK 64-Bit Server VM (build 21+35-2513, mixed mode, sharing) $ build/sbt test:package -Psparkr -Phive $ R/install-dev.sh; R/run-tests.sh ... sparkSQL: SparkSQL functions: .......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... ........................................................................................................................................................................................................................................................................................................................................................................................................... ... ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42644 from dongjoon-hyun/SPARK-44127. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…ql.execution.arrow tests in Java 21 ### What changes were proposed in this pull request? This PR aims to re-enable `PandasUDF` and `o.a.s.sql.execution.arrow` tests in Java 21. This depends on #42181 . ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run the following on Java 21. ``` $ java -version openjdk version "21" 2023-09-19 OpenJDK Runtime Environment (build 21+35-2513) OpenJDK 64-Bit Server VM (build 21+35-2513, mixed mode, sharing) $ build/sbt "sql/testOnly *.ArrowConvertersSuite" ... [info] Run completed in 5 seconds, 316 milliseconds. [info] Total number of tests run: 30 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 30, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. $ build/sbt "sql/testOnly *.SQLQueryTestSuite" ... [info] Run completed in 12 minutes, 4 seconds. [info] Total number of tests run: 629 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 629, failed 0, canceled 0, ignored 2, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42641 from dongjoon-hyun/SPARK-44097. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…21 after the new arrow version release ### What changes were proposed in this pull request? This PR aims to re-enable PySpark in Java 21. This depends on #42181 . ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42646 from panbingkun/SPARK-44302. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…va 21 ### What changes were proposed in this pull request? This PR aims to re-enable Arrow-based connect tests in Java 21. This depends on #42181. ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ java -version openjdk version "21-ea" 2023-09-19 OpenJDK Runtime Environment (build 21-ea+32-2482) OpenJDK 64-Bit Server VM (build 21-ea+32-2482, mixed mode, sharing) $ build/sbt "connect/test" -Phive ... [info] Run completed in 14 seconds, 136 milliseconds. [info] Total number of tests run: 858 [info] Suites: completed 20, aborted 0 [info] Tests: succeeded 858, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 44 s, completed Aug 23, 2023, 9:42:53 PM $ build/sbt "connect-client-jvm/test" -Phive ... [info] Run completed in 1 minute, 24 seconds. [info] Total number of tests run: 1220 [info] Suites: completed 24, aborted 0 [info] Tests: succeeded 1220, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [info] Passed: Total 1222, Failed 0, Errors 0, Passed 1222 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42643 from dongjoon-hyun/SPARK-44121. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…va 21 ### What changes were proposed in this pull request? This PR aims to re-enable Arrow-based connect tests in Java 21. This depends on #42181. ### Why are the changes needed? To have Java 21 test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? ``` $ java -version openjdk version "21-ea" 2023-09-19 OpenJDK Runtime Environment (build 21-ea+32-2482) OpenJDK 64-Bit Server VM (build 21-ea+32-2482, mixed mode, sharing) $ build/sbt "connect/test" -Phive ... [info] Run completed in 14 seconds, 136 milliseconds. [info] Total number of tests run: 858 [info] Suites: completed 20, aborted 0 [info] Tests: succeeded 858, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 44 s, completed Aug 23, 2023, 9:42:53 PM $ build/sbt "connect-client-jvm/test" -Phive ... [info] Run completed in 1 minute, 24 seconds. [info] Total number of tests run: 1220 [info] Suites: completed 24, aborted 0 [info] Tests: succeeded 1220, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [info] Passed: Total 1222, Failed 0, Errors 0, Passed 1222 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42643 from dongjoon-hyun/SPARK-44121. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a824a6d) Signed-off-by: Dongjoon Hyun <[email protected]>


What changes were proposed in this pull request?
The pr aims to upgrade arrow from 12.0.1 to 13.0.0.
Why are the changes needed?
Arrow 12.0.1 VS 13.0.0
apache/arrow@apache-arrow-12.0.1...apache-arrow-13.0.0
Arrow 13.0.0 is the first version to support Java 21.
When arrow version 12.0.1 running on Java21, the following error occurred:
After this PR, we can try to enable netty related testing in Java21.
Does this PR introduce any user-facing change?
No.
How was this patch tested?