[SPARK-44509][CONNECT][FOLLOW-UP] Add inheritable support in new job cancellation API #42149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Jul 25, 2023
| :class:`threading.Thread` but correctly inherits the inheritable properties specific | ||
| to JVM thread such as ``InheritableThreadLocal``. | ||
| Also, note that pinned thread mode does not close the connection from Python |
Member
Author
|
cc @zhengruifeng and @WeichenXu123 I need your look here. |
zhengruifeng
approved these changes
Jul 25, 2023
Contributor
|
LGTM, but I think we need @WeichenXu123 's approval for this PR |
HyukjinKwon
force-pushed
the
SPARK-44509-followup
branch
from
b03109f to
391ce44
Compare
Member
Author
|
All tests passed. The failed test is pip packaging test that happens after running all unittests. I will fix them separately at #42159. Merged to master and branch-3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a kind of a followup of #42120. This addresses my own comment at #42120 (comment) by adding the support of
InheritableThreadwith Spark Connect.Why are the changes needed?
In order to allow the thread local hierarchy supported in Scala side.
Does this PR introduce any user-facing change?
The main PR is not released out yet so it doesn't have user-facing change.
How was this patch tested?
Unittests were added.