[SPARK-44519][CONNECT] SparkConnectServerUtils generated incorrect parameters for jars #42121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters for jars
Contributor
Author
|
ping @LuciferYang cc @HyukjinKwon @zhengruifeng |
LuciferYang
approved these changes
Jul 24, 2023
HyukjinKwon
approved these changes
Jul 24, 2023
LuciferYang
pushed a commit
that referenced
this pull request
Jul 24, 2023
…rameters for jars ### What changes were proposed in this pull request? #41932 try to add test case for connect, then we found the maven build failure based on the bug discussed at #41932 (comment) After some communication, cloud-fan and zhengruifeng suggested to ignore the test case for connect. So I commit this PR to fix the bug. ### Why are the changes needed? Fix the bug that `SparkConnectServerUtils` generated incorrect parameters for jars. ### Does this PR introduce _any_ user-facing change? 'No'. Just update the inner implementation. ### How was this patch tested? N/A Closes #42121 from beliefer/SPARK-44519. Authored-by: Jiaan Geng <[email protected]> Signed-off-by: yangjie01 <[email protected]> (cherry picked from commit 4644344) Signed-off-by: yangjie01 <[email protected]>
Contributor
|
Merged into master and branch-3.5. Thanks @HyukjinKwon @beliefer |
Contributor
Author
|
@LuciferYang @HyukjinKwon Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41932 try to add test case for connect, then we found the maven build failure based on the bug discussed at #41932 (comment)
After some communication, @cloud-fan and @zhengruifeng suggested to ignore the test case for connect.
So I commit this PR to fix the bug.
Why are the changes needed?
Fix the bug that
SparkConnectServerUtilsgenerated incorrect parameters for jars.Does this PR introduce any user-facing change?
'No'.
Just update the inner implementation.
How was this patch tested?
N/A