[SPARK-44348][CONNECT][FOLLOW-UP] Avoid double slashes in the URI #42051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Jul 18, 2023
yaooqinn
approved these changes
Jul 18, 2023
Member
Author
|
Merged to master and branch-3.5. |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 18, 2023
### What changes were proposed in this pull request? This PR is a followup of #41942 that does `substring(1)` to remove the leading slash so it makes it relative parts from URI. Otherwise, it can end up with having double slashes in the middle. ### Why are the changes needed? To avoid having unnecessary double slashes ... and save one byte :-) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested. It's really trivial. Closes #42051 from HyukjinKwon/minor-change. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #41942 that does
substring(1)to remove the leading slash so it makes it relative parts from URI. Otherwise, it can end up with having double slashes in the middle.Why are the changes needed?
To avoid having unnecessary double slashes ... and save one byte :-)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested. It's really trivial.