[SPARK-44293][CONNECT] Fix invalid URI for custom JARs in Spark Connect #41844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicennial
commented
Jul 4, 2023
| |} | ||
| |val classLoaderUdf = udf(classLoadingTest _) | ||
| | | ||
| |val jarPath = Paths.get("$sparkHome/connector/connect/client/jvm/src/test/resources/TestHelloV2.jar").toUri |
Contributor
Author
There was a problem hiding this comment.
I feel like there must be a better way to pass in the JAR path here. Open to suggestions!
HyukjinKwon
reviewed
Jul 4, 2023
| // scalastyle:off classforname line.size.limit | ||
| val sparkHome = IntegrationTestUtils.sparkHome | ||
| val testJar = Paths | ||
| .get(s"$sparkHome/connector/connect/client/jvm/src/test/resources/TestHelloV2.jar") |
Member
There was a problem hiding this comment.
Looks fine but for doubly sure, does it need Scala 2.13 jar too, @LuciferYang ?
Contributor
Author
There was a problem hiding this comment.
Thanks! I've updated the code to account for the scala version
HyukjinKwon
approved these changes
Jul 4, 2023
Member
|
Merged to master. |
LuciferYang
added a commit
that referenced
this pull request
Sep 26, 2023
…ry files ### What changes were proposed in this pull request? The purpose of this pr is to clean up the binary files used to assist with Scala 2.12 testing. They include: - `core/src/test/resources/TestHelloV3_2.12.jar` and `core/src/test/resources/TestHelloV2_2.12.jar` added by SPARK-44246(#41789). - `connector/connect/client/jvm/src/test/resources/udf2.12` and `connector/connect/client/jvm/src/test/resources/udf2.12.jar` added by SPARK-43744(#42069) - `connector/connect/client/jvm/src/test/resources/TestHelloV2_2.12.jar` added by SPARK-44293(#41844) - `sql/hive/src/test/resources/regression-test-SPARK-8489/test-2.12.jar` added by SPARK-25304(#22308) ### Why are the changes needed? Spark 4.0 no longer supports Scala 2.12. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43106 from LuciferYang/SPARK-45321. Authored-by: yangjie01 <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixs the bug where invalid JAR URIs were being generated because the URI was stored as
artifactURI + "/" + target.toString(here,targetis the absolute path of the file) instead ofartifactURI + "/" + remoteRelativePath.toString(here, theremoteRelativePathis in the form ofjars/...)Why are the changes needed?
Without this change, Spark Connect users attempting to use a custom JAR (such as in UDFs) will hit task failure issue as an exception would be thrown during the JAR file fetch operation.
Example stacktrace:
Does this PR introduce any user-facing change?
No (the bug-fix is consistent with what users expect)
How was this patch tested?
New E2E test in
ReplE2ESuite.