Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jan 23, 2015

This reenables and fixes this test, after addressing two issues:

  • The Semaphore that was intended to be shared locally was being serialized and copied; it's now a static member in the companion object as in other tests
  • Later changes to Spark means that cancelling the first task will not cancel the shared stage and therefore the second task should succeed

…re a Semaphore locally as intended, and update expectation of failure in non-cancelled task
@SparkQA
Copy link

SparkQA commented Jan 23, 2015

Test build #26023 has started for PR 4180 at commit 43da66f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 23, 2015

Test build #26023 has finished for PR 4180 at commit 43da66f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26023/
Test PASSed.

@JoshRosen
Copy link
Contributor

LGTM, so I'm going to merge this into master (1.3.0). I've run into this same issue with semaphore serialization and ended up applying the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants