[SPARK-44254][SQL] Move QueryExecutionErrors that used by DataType to sql/api as DataTypeErrors #41794
Conversation
amaliujia
force-pushed
the
datatype_more_refactors
branch
from
c3c39c1 to
1d9c33c
Compare
There was a problem hiding this comment.
Do other similar items need to be moved? eg:
QueryExecutionErrors.unscaledValueTooLargeForPrecisionError(this, precision, scale)
It seems that it is only called in DataType.
There was a problem hiding this comment.
For those we haven't moved, they are using SQLConf inside and we are still discussing how to better deal withSQLConf now.
sql/api/pom.xml
Outdated
There was a problem hiding this comment.
def outOfDecimalTypeRangeError(str: UTF8String): SparkArithmeticException
There was a problem hiding this comment.
UTF8String stays into spark-unsafe.
amaliujia
force-pushed
the
datatype_more_refactors
branch
from
fa4f479 to
208e5c6
Compare
|
@amaliujia Could you adjust PR title and description according to your recent commit, please. |
amaliujia
changed the title
|
@MaxGekk tried to update title and description. |
|
+1, LGTM. Merging to master. |
4 participants
What changes were proposed in this pull request?
Moving some QueryExecutionErrors that are used by data types to
sql/apiand name those as DataType erros so that DataType can use those if DataType only stay insql/apimodule.Why are the changes needed?
Towards a simpler DataType interface.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test