Skip to content

Conversation

@guiyanakuang
Copy link
Member

What changes were proposed in this pull request?

This PR aims to update ORC to 1.8.4.

Why are the changes needed?

This will bring the following bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the BUILD label Jun 14, 2023
@guiyanakuang
Copy link
Member Author

cc @dongjoon-hyun

@wangyum
Copy link
Member

wangyum commented Jun 14, 2023

@guiyanakuang Please make the PR against the master branch. You can change it here:
image

@guiyanakuang
Copy link
Member Author

@guiyanakuang Please make the PR against the master branch. You can change it here: image

The plan after ORC community discussion is

Apache ORC 1.8.4 (2023-06-16, Yiqun Zhang) => Apache Spark 3.4.1
Apache ORC 1.9.0 (2023-06-30, Dongjoon Hyun) => Apache Spark 3.5.0

So I should have the right branch

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 14, 2023

Hi, @guiyanakuang and @wangyum .

Both of you are right and I'll release Apache ORC 1.9.0 in this month.

This is more like a timing issue where Apache Spark master branch is still using 1.8.3 because Apache ORC 1.9.0 is not released yet.

If Apache Spark master branch is already 1.9.0, this PR is suffient.

So, @guiyanakuang , could you make another PR for master branch too? I can merge both PRs sequently from master first and branch-3.4 second.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-44053][BUILD] Update ORC to 1.8.4 [SPARK-44053][BUILD][3.4] Update ORC to 1.8.4 Jun 14, 2023
@dongjoon-hyun
Copy link
Member

I updated the title of this PR to [SPARK-44053][BUILD][3.4] Update ORC to 1.8.4.
For your new PR for master branch, please use [SPARK-44053][BUILD] Update ORC to 1.8.4.

@guiyanakuang
Copy link
Member Author

I get it. Thanks @dongjoon-hyun and @wangyum

dongjoon-hyun pushed a commit that referenced this pull request Jun 14, 2023
### What changes were proposed in this pull request?

This PR aims to update ORC to 1.8.4.

### Why are the changes needed?

This will bring the following bug fixes.
- https://issues.apache.org/jira/projects/ORC/versions/12353041

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #41592 from guiyanakuang/ORC-1.8.4.

Authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

Merged to branch-3.4 for Apache Spark 3.4.0.

I merged #41593 first to master and merged this one.

@dongjoon-hyun
Copy link
Member

Welcome to the Apache Spark community again, @guiyanakuang !

snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
This PR aims to update ORC to 1.8.4.

This will bring the following bug fixes.
- https://issues.apache.org/jira/projects/ORC/versions/12353041

No.

Pass the CIs.

Closes apache#41592 from guiyanakuang/ORC-1.8.4.

Authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
### What changes were proposed in this pull request?

This PR aims to update ORC to 1.8.4.

### Why are the changes needed?

This will bring the following bug fixes.
- https://issues.apache.org/jira/projects/ORC/versions/12353041

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#41592 from guiyanakuang/ORC-1.8.4.

Authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
### What changes were proposed in this pull request?

This PR aims to update ORC to 1.8.4.

### Why are the changes needed?

This will bring the following bug fixes.
- https://issues.apache.org/jira/projects/ORC/versions/12353041

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#41592 from guiyanakuang/ORC-1.8.4.

Authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants