Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 8, 2023

What changes were proposed in this pull request?

This PR moves ResolveDefaultColumnsSuite from catalyst/analysis package to sql package.

Why are the changes needed?

To fix the code layout.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CI

@dongjoon-hyun
Copy link
Member Author

cc @dtenedor and @gengliangwang

@dtenedor
Copy link
Contributor

dtenedor commented Jun 8, 2023

LGTM! Thanks @dongjoon-hyun for the clean up.

@dongjoon-hyun
Copy link
Member Author

Thank you, @dtenedor and @gengliangwang

I verified the relocated suite manually.

$ build/sbt "sql/testOnly *.ResolveDefaultColumnsSuite"
...
[info] ResolveDefaultColumnsSuite:
12:21:59.363 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
[info] - column without default value defined (null as default) (4 seconds, 19 milliseconds)
[info] - column with default value defined (1 second, 28 milliseconds)
[info] - INSERT into partitioned tables (1 second, 435 milliseconds)
[info] - SPARK-43085: Column DEFAULT assignment for target tables with multi-part names (555 milliseconds)
[info] - SPARK-43313: Column default values with implicit coercion from provided values (473 milliseconds)
12:22:07.418 WARN org.apache.spark.sql.ResolveDefaultColumnsSuite:

===== POSSIBLE THREAD LEAK IN SUITE o.a.s.sql.ResolveDefaultColumnsSuite, threads: ForkJoinPool.commonPool-worker-27 (daemon=true), ForkJoinPool.commonPool-worker-19 (daemon=true), rpc-boss-3-1 (daemon=true), ForkJoinPool.commonPool-worker-5 (daemon=true), shuffle-boss-6-1 (daemon=true), ForkJoinPool.commonPool-worker-23 (daemon=true), ForkJoinPool.commonPool-worker-9 (daemon=true) =====
[info] Run completed in 9 seconds, 362 milliseconds.
[info] Total number of tests run: 5
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 5, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 28 s, completed Jun 8, 2023, 12:22:07 PM

dongjoon-hyun added a commit that referenced this pull request Jun 8, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package.

To fix the code layout.

No.

Pass the CI

Closes #41520 from dongjoon-hyun/move.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 07cc04d)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member Author

Merged to master/3.4.

@dongjoon-hyun dongjoon-hyun deleted the move branch June 8, 2023 19:51
czxm pushed a commit to czxm/spark that referenced this pull request Jun 12, 2023
### What changes were proposed in this pull request?

This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package.

### Why are the changes needed?

To fix the code layout.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CI

Closes apache#41520 from dongjoon-hyun/move.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package.

To fix the code layout.

No.

Pass the CI

Closes apache#41520 from dongjoon-hyun/move.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 07cc04d)
Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package.

To fix the code layout.

No.

Pass the CI

Closes apache#41520 from dongjoon-hyun/move.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 07cc04d)
Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package.

To fix the code layout.

No.

Pass the CI

Closes apache#41520 from dongjoon-hyun/move.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 07cc04d)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants