-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][SQL][TESTS] Move ResolveDefaultColumnsSuite to 'o.a.s.sql' #41520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dtenedor and @gengliangwang |
Contributor
|
LGTM! Thanks @dongjoon-hyun for the clean up. |
gengliangwang
approved these changes
Jun 8, 2023
Member
Author
|
Thank you, @dtenedor and @gengliangwang I verified the relocated suite manually. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 8, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package. To fix the code layout. No. Pass the CI Closes #41520 from dongjoon-hyun/move. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 07cc04d) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to master/3.4. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package. ### Why are the changes needed? To fix the code layout. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CI Closes apache#41520 from dongjoon-hyun/move. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package. To fix the code layout. No. Pass the CI Closes apache#41520 from dongjoon-hyun/move. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 07cc04d) Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package. To fix the code layout. No. Pass the CI Closes apache#41520 from dongjoon-hyun/move. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 07cc04d) Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
This PR moves `ResolveDefaultColumnsSuite` from `catalyst/analysis` package to `sql` package. To fix the code layout. No. Pass the CI Closes apache#41520 from dongjoon-hyun/move. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 07cc04d) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
ResolveDefaultColumnsSuitefromcatalyst/analysispackage tosqlpackage.Why are the changes needed?
To fix the code layout.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CI