[SPARK-43203][SQL] Move all Drop Table case to DataSource V2 #41348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Hisoka-X
force-pushed
the
SPARK-43203_drop_table_to_v2
branch
from
39268a4 to
bfd7c2f
Compare
Hisoka-X
commented
May 29, 2023
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
Outdated
Show resolved
Hide resolved
| isSameName(ident.qualifier :+ ident.name) && | ||
| isSameName(v1Ident.catalog.toSeq ++ v1Ident.database :+ v1Ident.table) | ||
|
|
||
| case SubqueryAlias(ident, HiveTableRelation(catalogTable, _, _, _, _)) => |
Member
Author
There was a problem hiding this comment.
Add support for HiveTableRelation in isMatchedTableOrView, so that can remove Cache normally when use hive catalog.
| try { | ||
| V1Table(catalog.getTableMetadata(ident.asTableIdentifier)) | ||
| } catch { | ||
| case _: NoSuchDatabaseException => |
Member
Author
There was a problem hiding this comment.
loadTable will return NoSuchDatabaseException, not same as v1 behavior.
Contributor
There was a problem hiding this comment.
does it cause test failures?
Member
Author
There was a problem hiding this comment.
Yes, the DerbyTableCatalogSuite:SPARK-42978: RENAME cannot qualify a new-table-Name with a schema-Name. will failed without this change.
cloud-fan
reviewed
May 31, 2023
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 31, 2023
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Jun 1, 2023
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 7, 2023
cloud-fan
reviewed
Jun 7, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jun 8, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/IdentifierImpl.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jun 8, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jun 8, 2023
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/DropTableSuite.scala
Show resolved
Hide resolved
Member
|
Is the test failure related? |
viirya
reviewed
Jun 8, 2023
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java
Outdated
Show resolved
Hide resolved
Member
Author
I think not, many PR can't pass sql - other tests at now. Seem ci have something wrong. |
Member
Author
Done, please wait. |
Member
Author
|
@cloud-fan @viirya Hi folks, the CI passed. Can we move forward next step? |
cloud-fan
approved these changes
Jun 19, 2023
Contributor
|
thanks, merging to master! |
Member
Author
|
Thanks @cloud-fan @viirya |
Contributor
|
I unfortunately created this initially as improvement. It is actually a bug and regression, which breaks DROP in custom sessions catalogs. Can we include it in 3.4.2? |
Member
|
I'm okay with changing it to bug and backport to 3.4.2. cc @cloud-fan |
Hisoka-X
added a commit
to Hisoka-X/spark
that referenced
this pull request
Jun 28, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. 7. If you want to add a new configuration, please read the guideline first for naming configurations in 'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'. 8. If you want to add or modify an error type or message, please read the guideline first in 'core/src/main/resources/error/README.md'. --> ### What changes were proposed in this pull request? In order to fix DROP table behavior in session catalog cause by apache#37879. Because we always invoke V1 drop logic if the identifier looks like a V1 identifier. This is a big blocker for external data sources that provide custom session catalogs. So this PR move all Drop Table case to DataSource V2 (use drop table to drop view not include). More information please check https://github.com/apache/spark/pull/37879/files#r1170501180 <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 3. If you fix some SQL features, you can provide some references of other DBMSes. 4. If there is design documentation, please add the link. 5. If there is a discussion in the mailing list, please add the link. --> ### Why are the changes needed? Move Drop Table case to DataSource V2 to fix bug and prepare for remove drop table v1. <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> ### Does this PR introduce _any_ user-facing change? No <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master. If no, write 'No'. --> ### How was this patch tested? Tested by: - V2 table catalog tests: `org.apache.spark.sql.execution.command.v2.DropTableSuite` - V1 table catalog tests: `org.apache.spark.sql.execution.command.v1.DropTableSuiteBase` <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> Closes apache#41348 from Hisoka-X/SPARK-43203_drop_table_to_v2. Authored-by: Jia Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 32a5db4)
yaooqinn
pushed a commit
that referenced
this pull request
Jul 18, 2023
… null table ### What changes were proposed in this pull request? This is a followup of #41348 . Previously `V2SessionCatalog.dropTable` treated null table as table not exists, but #41348 broke it. This PR fixes it. ### Why are the changes needed? to keep old behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes #42056 from cloud-fan/mm. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Kent Yao <[email protected]>
yaooqinn
pushed a commit
that referenced
this pull request
Jul 18, 2023
… null table ### What changes were proposed in this pull request? This is a followup of #41348 . Previously `V2SessionCatalog.dropTable` treated null table as table not exists, but #41348 broke it. This PR fixes it. ### Why are the changes needed? to keep old behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes #42056 from cloud-fan/mm. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 704131b) Signed-off-by: Kent Yao <[email protected]>
Hisoka-X
pushed a commit
to Hisoka-X/spark
that referenced
this pull request
Jul 26, 2023
… null table ### What changes were proposed in this pull request? This is a followup of apache#41348 . Previously `V2SessionCatalog.dropTable` treated null table as table not exists, but apache#41348 broke it. This PR fixes it. ### Why are the changes needed? to keep old behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes apache#42056 from cloud-fan/mm. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 704131b)
Hisoka-X
added a commit
to Hisoka-X/spark
that referenced
this pull request
Aug 29, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. 7. If you want to add a new configuration, please read the guideline first for naming configurations in 'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'. 8. If you want to add or modify an error type or message, please read the guideline first in 'core/src/main/resources/error/README.md'. --> ### What changes were proposed in this pull request? In order to fix DROP table behavior in session catalog cause by apache#37879. Because we always invoke V1 drop logic if the identifier looks like a V1 identifier. This is a big blocker for external data sources that provide custom session catalogs. So this PR move all Drop Table case to DataSource V2 (use drop table to drop view not include). More information please check https://github.com/apache/spark/pull/37879/files#r1170501180 <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 3. If you fix some SQL features, you can provide some references of other DBMSes. 4. If there is design documentation, please add the link. 5. If there is a discussion in the mailing list, please add the link. --> ### Why are the changes needed? Move Drop Table case to DataSource V2 to fix bug and prepare for remove drop table v1. <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> ### Does this PR introduce _any_ user-facing change? No <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master. If no, write 'No'. --> ### How was this patch tested? Tested by: - V2 table catalog tests: `org.apache.spark.sql.execution.command.v2.DropTableSuite` - V1 table catalog tests: `org.apache.spark.sql.execution.command.v1.DropTableSuiteBase` <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> Closes apache#41348 from Hisoka-X/SPARK-43203_drop_table_to_v2. Authored-by: Jia Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 32a5db4)
Hisoka-X
pushed a commit
to Hisoka-X/spark
that referenced
this pull request
Aug 29, 2023
… null table ### What changes were proposed in this pull request? This is a followup of apache#41348 . Previously `V2SessionCatalog.dropTable` treated null table as table not exists, but apache#41348 broke it. This PR fixes it. ### Why are the changes needed? to keep old behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes apache#42056 from cloud-fan/mm. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 704131b)
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 8, 2023
### What changes were proposed in this pull request? cherry pick #41348 and #42056 , this a bug fixed should be included in 3.4.2 ### Why are the changes needed? Fix DROP table behavior in session catalog ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tested by: - V2 table catalog tests: `org.apache.spark.sql.execution.command.v2.DropTableSuite` - V1 table catalog tests: `org.apache.spark.sql.execution.command.v1.DropTableSuiteBase` Closes #41765 from Hisoka-X/move_drop_table_v2_to_3.4.2. Lead-authored-by: Jia Fan <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. 7. If you want to add a new configuration, please read the guideline first for naming configurations in 'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'. 8. If you want to add or modify an error type or message, please read the guideline first in 'core/src/main/resources/error/README.md'. --> In order to fix DROP table behavior in session catalog cause by apache#37879. Because we always invoke V1 drop logic if the identifier looks like a V1 identifier. This is a big blocker for external data sources that provide custom session catalogs. So this PR move all Drop Table case to DataSource V2 (use drop table to drop view not include). More information please check https://github.com/apache/spark/pull/37879/files#r1170501180 <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 3. If you fix some SQL features, you can provide some references of other DBMSes. 4. If there is design documentation, please add the link. 5. If there is a discussion in the mailing list, please add the link. --> Move Drop Table case to DataSource V2 to fix bug and prepare for remove drop table v1. <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> No <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master. If no, write 'No'. --> Tested by: - V2 table catalog tests: `org.apache.spark.sql.execution.command.v2.DropTableSuite` - V1 table catalog tests: `org.apache.spark.sql.execution.command.v1.DropTableSuiteBase` <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. --> Closes apache#41348 from Hisoka-X/SPARK-43203_drop_table_to_v2. Authored-by: Jia Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 32a5db4)
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
… null table ### What changes were proposed in this pull request? This is a followup of apache#41348 . Previously `V2SessionCatalog.dropTable` treated null table as table not exists, but apache#41348 broke it. This PR fixes it. ### Why are the changes needed? to keep old behavior. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes apache#42056 from cloud-fan/mm. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Kent Yao <[email protected]>
|
I found if you create a management table in spark 3.5.1, you cannot delete the path when dropping the table. I think this is a bug. It can be deleted correctly in spark 3.3. |
|
Contributor
|
@gaecoli thanks for reporting the bug! Can you create a JIRA ticket and include the reproduce steps? |
i don't have permission to connect to spark jira |
Contributor
|
or you can post the problem description and repro here and I can help to create the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to fix DROP table behavior in session catalog cause by #37879. Because we always invoke V1 drop logic if the identifier looks like a V1 identifier. This is a big blocker for external data sources that provide custom session catalogs.
So this PR move all Drop Table case to DataSource V2 (use drop table to drop view not include). More information please check https://github.com/apache/spark/pull/37879/files#r1170501180
Why are the changes needed?
Move Drop Table case to DataSource V2 to fix bug and prepare for remove drop table v1.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested by:
org.apache.spark.sql.execution.command.v2.DropTableSuiteorg.apache.spark.sql.execution.command.v1.DropTableSuiteBase