[SPARK-43779][SQL] ParseToDate should load the EvalMode in main thread #41298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
I needed to re-generate the golden files. |
cloud-fan
reviewed
May 25, 2023
| extends RuntimeReplaceable with ImplicitCastInputTypes with TimeZoneAwareExpression { | ||
|
|
||
| override lazy val replacement: Expression = format.map { f => | ||
| Cast(GetTimestamp(left, f, TimestampType, timeZoneId), DateType, timeZoneId) |
Contributor
There was a problem hiding this comment.
can we pass evalMode to cast here as well?
cloud-fan
reviewed
May 25, 2023
| emp 4 100.0 | ||
| emp 5 1000.0 | ||
| emp 6 - no dept 500.0 | ||
| java.lang.IllegalArgumentException |
Contributor
Author
There was a problem hiding this comment.
Auto golden file regeneration gives this update
cloud-fan
reviewed
May 25, 2023
| override lazy val replacement: Expression = format.map { f => | ||
| Cast(GetTimestamp(left, f, TimestampType, timeZoneId), DateType, timeZoneId) | ||
| }.getOrElse(Cast(left, DateType, timeZoneId)) // backwards compatibility | ||
| Cast(GetTimestamp(left, f, TimestampType, timeZoneId, ansiEnabled), DateType, timeZoneId) |
Contributor
There was a problem hiding this comment.
the Cast here still doesn't have the evalMod passed... But it's a good catch that we should pass ansiEnabled to GetTimestamp
Contributor
Author
There was a problem hiding this comment.
hmmm oops I see what is missing. Added.
cloud-fan
approved these changes
May 29, 2023
cloud-fan
approved these changes
May 29, 2023
Contributor
|
thanks, merging to master! |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? ParseToDate should load the EvalMode in main thread instead of loading it in a lazy val. ### Why are the changes needed? This is because it is sometimes hard to estimate when the lazy val is executed while the SQLConf where we load the EvalMode is thread local. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes apache#41298 from amaliujia/SPARK-43779. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ParseToDate should load the EvalMode in main thread instead of loading it in a lazy val.
Why are the changes needed?
This is because it is sometimes hard to estimate when the lazy val is executed while the SQLConf where we load the EvalMode is thread local.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT