-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-43988][INFRA] Add maven testing GitHub Action task for connect client module #41253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
67406ca
add independent maven testing GA task
LuciferYang a9e81e1
Merge branch 'upmaster' into test-connect-maven
LuciferYang 4d0efc5
Merge branch 'apache:master' into test-connect-maven
LuciferYang a87f5ac
Merge branch 'apache:master' into test-connect-maven
LuciferYang 47860bd
add comments
LuciferYang 3af0ca7
Merge branch 'apache:master' into test-connect-maven
LuciferYang 02cfafe
for ga
LuciferYang ac6f7b9
copy fix tty part
LuciferYang 5b8d634
add upload result
LuciferYang 34d3fef
Merge branch 'upmaster' into test-connect-maven
LuciferYang 5e623e4
add set -e
LuciferYang 24bc192
for ga
LuciferYang ebb06a7
remove
LuciferYang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,7 @@ jobs: | |
| \"docker-integration-tests\": \"$docker\", | ||
| \"scala-213\": \"true\", | ||
| \"java-11-17\": \"true\", | ||
| \"connect-maven\": \"true\", | ||
| \"lint\" : \"true\", | ||
| \"k8s-integration-tests\" : \"true\", | ||
| \"breaking-changes-buf\" : \"true\", | ||
|
|
@@ -728,6 +729,68 @@ jobs: | |
| ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Djava.version=${JAVA_VERSION/-ea} install | ||
| rm -rf ~/.m2/repository/org/apache/spark | ||
|
|
||
| connect-maven: | ||
| needs: precondition | ||
| if: fromJson(needs.precondition.outputs.required).connect-maven == 'true' | ||
| name: Test connect modules with Maven | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - ${{ inputs.java }} | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout Spark repository | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| repository: apache/spark | ||
| ref: ${{ inputs.branch }} | ||
| - name: Sync the current branch with the latest in Apache Spark | ||
| if: github.repository != 'apache/spark' | ||
| run: | | ||
| git fetch https://github.com/$GITHUB_REPOSITORY.git ${GITHUB_REF#refs/heads/} | ||
| git -c user.name='Apache Spark Test Account' -c user.email='[email protected]' merge --no-commit --progress --squash FETCH_HEAD | ||
| git -c user.name='Apache Spark Test Account' -c user.email='[email protected]' commit -m "Merged commit" --allow-empty | ||
| - name: Cache Scala, SBT and Maven | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| build/apache-maven-* | ||
| build/scala-* | ||
| build/*.jar | ||
| ~/.sbt | ||
| key: build-${{ hashFiles('**/pom.xml', 'project/build.properties', 'build/mvn', 'build/sbt', 'build/sbt-launch-lib.bash', 'build/spark-build-info') }} | ||
| restore-keys: | | ||
| build- | ||
| - name: Cache Maven local repository | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ~/.m2/repository | ||
| key: java${{ matrix.java }}-maven-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: | | ||
| java${{ matrix.java }}-maven- | ||
| - name: Install Java ${{ matrix.java }} | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: ${{ matrix.java }} | ||
| - name: Build with Maven | ||
| run: | | ||
| export MAVEN_OPTS="-Xss64m -Xmx2g -XX:ReservedCodeCacheSize=1g -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN" | ||
| export MAVEN_CLI_OPTS="--no-transfer-progress" | ||
| export JAVA_VERSION=${{ matrix.java }} | ||
| # It uses Maven's 'install' intentionally, see https://github.com/apache/spark/pull/26414. | ||
| # 1. Test without -Phive | ||
| ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Djava.version=${JAVA_VERSION/-ea} install | ||
| ./build/mvn $MAVEN_CLI_OPTS -Djava.version=${JAVA_VERSION/-ea} test -pl connector/connect/server | ||
| ./build/mvn $MAVEN_CLI_OPTS -Djava.version=${JAVA_VERSION/-ea} test -pl connector/connect/client/jvm | ||
| # 2. Test with -Phive | ||
| ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Djava.version=${JAVA_VERSION/-ea} install -pl assembly -Phive | ||
| ./build/mvn $MAVEN_CLI_OPTS -Djava.version=${JAVA_VERSION/-ea} test -pl connector/connect/server -Phive | ||
| ./build/mvn $MAVEN_CLI_OPTS -Djava.version=${JAVA_VERSION/-ea} test -pl connector/connect/client/jvm -Phive | ||
| rm -rf ~/.m2/repository/org/apache/spark | ||
|
|
||
| scala-213: | ||
| needs: precondition | ||
| if: fromJson(needs.precondition.outputs.required).scala-213 == 'true' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
friendly ping @HyukjinKwon @hvanhovell I want to add a independent maven testing GA task for connect modules due to there are always some Maven tests fail, and we can only check them afterwards, see:
I found today, do you think it's ok?
Also cc @dongjoon-hyun