[SPARK-43548][SS] Remove workaround for HADOOP-16255 #41209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @attilapiros @viirya @sunchao @pan3793 FYI |
Contributor
Author
|
viirya
approved these changes
May 18, 2023
LuciferYang
approved these changes
May 18, 2023
pan3793
approved these changes
May 18, 2023
Member
|
Hmm .. does that mean Hadoop 3.2.0 won't work with this? |
Member
|
Hm, we currently build Spark w/ Hadoop 3.3.0 by default it might be fine but I would also ask some more looks e.g., @srowen @mridulm @tgravescs @dongjoon-hyun |
Member
|
Spark only works with Hadoop 3.3.1+ at the moment, as we discovered in #40847. We can potentially make it work with Hadoop 3.2.2+ if there's a workaround for https://issues.apache.org/jira/browse/SPARK-40039 which uses Hadoop API that only exist in Hadoop 3.3.1+. It definitely won't work with Hadoop 3.2.0 due to some shaded client related issues. |
Member
|
Thanks for clarification. Lgtm2 |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? The pr aims to remove workaround for HADOOP-16255. https://issues.apache.org/jira/browse/HADOOP-16255 ### Why are the changes needed? - Because HADOOP-16255 has been fix after hadoop version 3.1.2. Spark support hadoop version: >= 3.2.2 or >= 3.3.1 - Make code clean. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#41209 from panbingkun/SPARK-43548. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to remove workaround for HADOOP-16255.
https://issues.apache.org/jira/browse/HADOOP-16255
Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.