Skip to content

[SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException#4119

Closed
jongyoul wants to merge 4 commits intoapache:masterfrom
jongyoul:SPARK-5333
Closed

[SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException#4119
jongyoul wants to merge 4 commits intoapache:masterfrom
jongyoul:SPARK-5333

Conversation

@jongyoul
Copy link
Member

@jongyoul jongyoul commented Jan 20, 2015

  • Rewind ByteBuffer before making ByteString

@jongyoul
Copy link
Member Author

jongyoul commented Jan 20, 2015

/cc @JoshRosen This is related by SPARK-4014 #3849. Review this PR, please.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25813 has started for PR 4119 at commit 2190606.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25813 has finished for PR 4119 at commit 2190606.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25813/
Test FAILed.

@jongyoul
Copy link
Member Author

jongyoul commented Jan 20, 2015

retest this, please.

@jongyoul
Copy link
Member Author

jongyoul commented Jan 20, 2015

I've added license information.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25815 has started for PR 4119 at commit 4141f58.

  • This patch merges cleanly.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25814/
Test FAILed.

@jongyoul
Copy link
Member Author

jongyoul commented Jan 20, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25816 has started for PR 4119 at commit 4141f58.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25815 has finished for PR 4119 at commit 4141f58.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25815/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25816 has finished for PR 4119 at commit 4141f58.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25816/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25820 has started for PR 4119 at commit c6693a8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25820 has finished for PR 4119 at commit c6693a8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25820/
Test PASSed.

@JoshRosen
Copy link
Contributor

JoshRosen commented Jan 20, 2015

Nice catch; I guess this wasn't covered by the original tests, so I should have included tests for MesosTaskLaunchData. I'm going to merge this into master (1.3.0).

JoshRosen
JoshRosen reviewed Jan 20, 2015
View reviewed changes
core/src/test/scala/org/apache/spark/scheduler/mesos/MesosTaskLaunchDataSuite.scala
Copy link
Contributor

@JoshRosen JoshRosen Jan 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to add one newline here so that the Spark import is in its own section.

@JoshRosen
Copy link
Contributor

JoshRosen commented Jan 20, 2015

I'm also amending the commit message to say "(This fixes a bug introduced in #3849 / SPARK-4014)"

@asfgit asfgit closed this in 9d9294a Jan 20, 2015
bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 21, 2015
@jongyoul @bomeng
[SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException
03646d8 
- Rewind ByteBuffer before making ByteString

(This fixes a bug introduced in apache#3849 / SPARK-4014)

Author: Jongyoul Lee <jongyoul@gmail.com>

Closes apache#4119 from jongyoul/SPARK-5333 and squashes the following commits:

c6693a8 [Jongyoul Lee] [SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException - changed logDebug location
4141f58 [Jongyoul Lee] [SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException - Added license information
2190606 [Jongyoul Lee] [SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException - Adjusted imported libraries
b7f5517 [Jongyoul Lee] [SPARK-5333][Mesos] MesosTaskLaunchData occurs BufferUnderflowException - Rewind ByteBuffer before making ByteString
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jongyoul @SparkQA @AmplabJenkins @JoshRosen