[SPARK-43398][CORE] Executor timeout should be max of idle shuffle and rdd timeout #41082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dongjoon-hyun help take a look? |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
The removed code seems to be originated from Apache Spark 3.0.0. Could you give a correct Affected Versions to SPARK-43398 if you think this is a bug, @warrenzhu25 ?
Contributor
Author
Done. |
warrenzhu25
force-pushed
the
max-timeout
branch
2 times, most recently
from
af27199 to
11319ec
Compare
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
Outdated
Show resolved
Hide resolved
warrenzhu25
force-pushed
the
max-timeout
branch
2 times, most recently
from
7fb6690 to
4ed4c2d
Compare
mridulm
approved these changes
Jun 10, 2023
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
The changes look good to me.
Thanks for helping refine this @dongjoon-hyun !
Member
|
Merged to master/3.4/3.3. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 12, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes #41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7107742) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 12, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes #41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7107742) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Also, cc @Ngone51 |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes apache#41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes apache#41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7107742) Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes apache#41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7107742) Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…d rdd timeout ### What changes were proposed in this pull request? Executor timeout should be max of idle, shuffle and rdd timeout ### Why are the changes needed? Wrong timeout value when combining idle, shuffle and rdd timeout ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added test in `ExecutorMonitorSuite` Closes apache#41082 from warrenzhu25/max-timeout. Authored-by: Warren Zhu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7107742) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Executor timeout should be max of idle, shuffle and rdd timeout
Why are the changes needed?
Wrong timeout value when combining idle, shuffle and rdd timeout
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added test in
ExecutorMonitorSuite