[SPARK-43342][K8S] Support driver and executors to shared same Kubernetes PVC #41057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor PVC dynamic allocation failure" This reverts commit b065c94.
Contributor
Author
|
@dongjoon-hyun @cometta would be good if you have time to review this PR |
| CONTAINER_MOUNT_PATH) | ||
| .set(s"spark.kubernetes.executor.volumes.persistentVolumeClaim.data.options.claimName", | ||
| PVC_NAME) | ||
| .set(s"spark.executor.instances", "2") |
Member
There was a problem hiding this comment.
Sorry but I would disagree with this test case because the underlying is not NFS.
Contributor
Author
There was a problem hiding this comment.
I'm trying to see if it's possible to set up NFS in k8s integration testing.
dongjoon-hyun
requested changes
May 5, 2023
Member
|
I wrote a clean-revert PR with your authorship. Reverting PR should follow this style instead of claiming a new contribution like |
Contributor
Author
|
Replaced this with #41069 |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 7, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #41057 Closes #41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 7, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #41057 Closes #41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts SPARK-39006 and add a case of sharing the same PVC between the driver and multiple executors in PV testing of integration testing.
Some PV types (such as NFS) support data sharing via the same PVC for multiple Pods. However, SPARK-39006 broke this scenario, causing multiple Pods unable to share the same PVC.
Why are the changes needed?
This is regression caused by SPARK-39006.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests, and added test scenarios