[SPARK-43377][SQL] Enable spark.sql.thriftServer.interruptOnCancel by default
#41047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuszsompolski
approved these changes
May 4, 2023
Contributor
Author
|
The CI has passed with |
HyukjinKwon
approved these changes
May 5, 2023
dongjoon-hyun
approved these changes
May 5, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @ulysses-you , @juliuszsompolski , @HyukjinKwon .
Merged to master for Apache Spark 3.5.0.
Contributor
Author
|
thank you @dongjoon-hyun @HyukjinKwon @juliuszsompolski |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…by default ### What changes were proposed in this pull request? This pr enables `spark.sql.thriftServer.interruptOnCancel` by default ### Why are the changes needed? Address the comment apache#30481 (comment) ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? Pass CI Closes apache#41047 from ulysses-you/33526-F. Authored-by: ulysses-you <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr enables
spark.sql.thriftServer.interruptOnCancelby defaultWhy are the changes needed?
Address the comment #30481 (comment)
Does this PR introduce any user-facing change?
yes
How was this patch tested?
Pass CI