[SPARK-43250][SQL] Replace the error class _LEGACY_ERROR_TEMP_2014 with an internal error#40951
Closed
amousavigourabi wants to merge 8 commits intoapache:masterfrom
Closed
[SPARK-43250][SQL] Replace the error class _LEGACY_ERROR_TEMP_2014 with an internal error#40951amousavigourabi wants to merge 8 commits intoapache:masterfrom
_LEGACY_ERROR_TEMP_2014 with an internal error#40951amousavigourabi wants to merge 8 commits intoapache:masterfrom
Conversation
Replaces the error class _LEGACY_ERROR_TEMP_2014 with an internal error and updates the error message.
Line >100 chars got split up
amousavigourabi
changed the title
_LEGACY_ERROR_TEMP_2014 with an internal error_LEGACY_ERROR_TEMP_2014 with an internal error
Contributor
Author
|
@MaxGekk could you help review this? |
MaxGekk
requested changes
May 1, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
…xecutionErrors.scala Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
Member
|
+1, LGTM. Merging to master. |
Member
|
@amousavigourabi Congratulations with your first contribution to Apache Spark! |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…with an internal error ### What changes were proposed in this pull request? In this PR I propose to replace the legacy error class `_LEGACY_ERROR_TEMP_2014`, added as an `IllegalArgumentException` to avoid non-exhaustive case-matching in apache#22014, with an internal error as it is not triggered by the user space. ### Why are the changes needed? As the error is not triggered by the user space, the legacy error class can be replaced by an internal error. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No new tests were added and no tests needed changing because of the nature of the updated error class. Closes apache#40951 from amousavigourabi/add-new-function-internal-error. Lead-authored-by: amousavigourabi <28668597+amousavigourabi@users.noreply.github.com> Co-authored-by: Atour <28668597+amousavigourabi@users.noreply.github.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose to replace the legacy error class
_LEGACY_ERROR_TEMP_2014, added as anIllegalArgumentExceptionto avoid non-exhaustive case-matching in #22014, with an internal error as it is not triggered by the user space.Why are the changes needed?
As the error is not triggered by the user space, the legacy error class can be replaced by an internal error.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No new tests were added and no tests needed changing because of the nature of the updated error class.