Skip to content

[MLlib] [SPARK-5301] Missing conversions and operations on IndexedRowMatrix and CoordinateMatrix#4089

Closed
rezazadeh wants to merge 5 commits intoapache:masterfrom
rezazadeh:matutils
Closed

[MLlib] [SPARK-5301] Missing conversions and operations on IndexedRowMatrix and CoordinateMatrix#4089
rezazadeh wants to merge 5 commits intoapache:masterfrom
rezazadeh:matutils

Conversation

@rezazadeh
Copy link
Contributor

@rezazadeh rezazadeh commented Jan 17, 2015

  • Transpose is missing from CoordinateMatrix (this is cheap to compute, so it should be there)
  • IndexedRowMatrix should be convertable to CoordinateMatrix (conversion added)

Tests for both added.

@SparkQA
Copy link

SparkQA commented Jan 17, 2015

Test build #25708 has started for PR 4089 at commit cb10ae5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 17, 2015

Test build #25708 has finished for PR 4089 at commit cb10ae5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 17, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25708/
Test PASSed.

mengxr
mengxr reviewed Jan 21, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala Outdated
Copy link
Contributor

@mengxr mengxr Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array -> Iterator. This is inside a flat map. We don't need to create an temp Array.

x -> i?

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25871 has started for PR 4089 at commit bbc907a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25872 has started for PR 4089 at commit ec5238b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25871 has finished for PR 4089 at commit bbc907a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25871/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25872 has finished for PR 4089 at commit ec5238b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25872/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Jan 21, 2015

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in aa1e22b Jan 21, 2015
@rezazadeh
Copy link
Contributor Author

rezazadeh commented Jan 21, 2015

Thanks @mengxr!

bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 22, 2015
@bomeng
[MLlib] [SPARK-5301] Missing conversions and operations on IndexedRow…
2994c24 
…Matrix and CoordinateMatrix

* Transpose is missing from CoordinateMatrix (this is cheap to compute, so it should be there)
* IndexedRowMatrix should be convertable to CoordinateMatrix (conversion added)

Tests for both added.

Author: Reza Zadeh <reza@databricks.com>

Closes apache#4089 from rezazadeh/matutils and squashes the following commits:

ec5238b [Reza Zadeh] Array -> Iterator to avoid temp array
3ce0b5d [Reza Zadeh] Array -> Iterator
bbc907a [Reza Zadeh] Use 'i' for index, and zipWithIndex
cb10ae5 [Reza Zadeh] remove unnecessary import
a7ae048 [Reza Zadeh] Missing linear algebra utilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rezazadeh @SparkQA @AmplabJenkins @mengxr