[SPARK-43231][ML][PYTHON][CONNECT][TESTS] Reduce the memory requirement in torch-related tests #40874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Apr 21, 2023
zhengruifeng
changed the title
zhengruifeng
changed the title
Contributor
Author
|
except one run failed due to something unrelated, in all other 10 runs the torch tests passed successfully. |
Contributor
Author
|
merged to master |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 13, 2023
…cal-cluster tests ### What changes were proposed in this pull request? This PR is a followup of #41942 that reduces the memory used in tests. ### Why are the changes needed? To reduce the memory used in GitHub Actions test. This is consistent with: https://github.com/apache/spark/blob/master/python/pyspark/ml/tests/connect/test_parity_torch_distributor.py#L67C55-L67C58 See also #40874 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran the tests in my local to verify the change. Closes #41977 from HyukjinKwon/SPARK-44348-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce the memory requirement in torch-related tests
Why are the changes needed?
The computation in torch distributor actually happens in the external torch processes, and the Github Action resources is very limited, this PR tries to make related tests more stable
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
CI, let me keep merging oncoming commits from master to see whether this change is stable enough