[SPARK-42733][CONNECT][Followup] Write without path or table #40358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
reviewed
Mar 10, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
Outdated
Show resolved
Hide resolved
ueshin
reviewed
Mar 10, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Mar 14, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 14, 2023
Fixes `DataFrameWriter.save` to work without path or table parameter. Added support of jdbc method in the writer as it is one of the impl that does not contains a path or table. DataFrameWriter.save should work without path parameter because some data sources, such as jdbc, noop, works without those parameters. The follow up fix for scala client of #40356 No Unit and E2E test Closes #40358 from zhenlineo/write-without-path-table. Authored-by: Zhen Li <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 93334e2) Signed-off-by: Hyukjin Kwon <[email protected]>
| spark.range(10).write.format("noop").mode("append").save() | ||
| } | ||
|
|
||
| test("write jdbc") { |
Member
There was a problem hiding this comment.
This seems to break branch-3.4 somehow. I'm checking it now.
[info] - write jdbc *** FAILED *** (527 milliseconds)
[info] io.grpc.StatusRuntimeException: INTERNAL: No suitable driver
[info] at io.grpc.Status.asRuntimeException(Status.java:535)
Contributor
Author
There was a problem hiding this comment.
@dongjoon-hyun I checked branch-3.4 locally and I can run the following without error:
build/sbt -Phive -Pconnect package
build/sbt "connect-client-jvm/test"
Member
There was a problem hiding this comment.
To @zhenlineo , I reproduced the error locally in this way on branch-3.4 while the same command works in master.
$ build/sbt -Phive -Phadoop-3 assembly/package "protobuf/test" "connect-common/test" "connect/test" "connect-client-jvm/test"
...
[info] ClientE2ETestSuite:
[info] - spark result schema (319 milliseconds)
[info] - spark result array (350 milliseconds)
[info] - eager execution of sql (18 seconds, 3 milliseconds)
[info] - simple dataset (1 second, 194 milliseconds)
[info] - SPARK-42665: Ignore simple udf test until the udf is fully implemented. !!! IGNORED !!!
[info] - read and write (1 second, 32 milliseconds)
[info] - read path collision (32 milliseconds)
[info] - write table (5 seconds, 349 milliseconds)
[info] - write without table or path (170 milliseconds)
[info] - write jdbc *** FAILED *** (325 milliseconds)
[info] io.grpc.StatusRuntimeException: INTERNAL: No suitable driver
Member
There was a problem hiding this comment.
In addition, please see the CI. It's broken consistently.
Contributor
Author
There was a problem hiding this comment.
@dongjoon-hyun Be free to revert it in 3.4 and I will take a better look late today or tomorrow. Thanks. I can send a PR target at 3.4 directly. Or whatever is the easiest.
Member
There was a problem hiding this comment.
From my side, #40358 (comment) also failed.
$ build/sbt -Phive -Pconnect package
$ build/sbt "connect-client-jvm/test"
...
[info] ClientE2ETestSuite:
[info] - spark result schema (290 milliseconds)
[info] - spark result array (290 milliseconds)
[info] - eager execution of sql (15 seconds, 819 milliseconds)
[info] - simple dataset (1 second, 28 milliseconds)
[info] - SPARK-42665: Ignore simple udf test until the udf is fully implemented. !!! IGNORED !!!
[info] - read and write (929 milliseconds)
[info] - read path collision (31 milliseconds)
[info] - write table (4 seconds, 540 milliseconds)
[info] - write without table or path (348 milliseconds)
[info] - write jdbc *** FAILED *** (365 milliseconds)
[info] io.grpc.StatusRuntimeException: INTERNAL: No suitable driver
...
In this case, the usual suspect is Java. GitHub Action CI and I'm using Java 8.
Contributor
Author
There was a problem hiding this comment.
@dongjoon-hyun I saw the 3.4 build went back to green. Is this bf9c4b9 the fix? Is there still a problem that I shall fix?
Contributor
Author
There was a problem hiding this comment.
@dongjoon-hyun Aha, I saw the fix ab7c4f8. Thanks a lot!
Member
There was a problem hiding this comment.
Yes, it's resolved for now. Thank you for checking, @zhenlineo !
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
Fixes `DataFrameWriter.save` to work without path or table parameter. Added support of jdbc method in the writer as it is one of the impl that does not contains a path or table. DataFrameWriter.save should work without path parameter because some data sources, such as jdbc, noop, works without those parameters. The follow up fix for scala client of apache#40356 No Unit and E2E test Closes apache#40358 from zhenlineo/write-without-path-table. Authored-by: Zhen Li <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 93334e2) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes
DataFrameWriter.saveto work without path or table parameter.Added support of jdbc method in the writer as it is one of the impl that does not contains a path or table.
Why are the changes needed?
DataFrameWriter.save should work without path parameter because some data sources, such as jdbc, noop, works without those parameters.
The follow up fix for scala client of #40356
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit and E2E test