[SPARK-42702][SPARK-42623][SQL] Support parameterized query in subquery and CTE #40333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srielau
approved these changes
Mar 8, 2023
Contributor
There was a problem hiding this comment.
Is "query parameters" a term? I thought we go by "parameter marker". Either way we can be more descriptive.
Suggested change
| "Query parameters in Command." | |
| "Parameter markers in a DDL statement. Parameter markers must only be used in a query, or DML statement. Usage within CREATE or ALTER is unsupported." |
Contributor
There was a problem hiding this comment.
Suggested change
| "PARAMETERIZED_COMMAND" : { | |
| "PARAMETERIZED_DDL" : { |
Member
There was a problem hiding this comment.
If you don't mind, can we have a negative test case for this case-sensitive?
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Also, cc @sunchao , @huaxingao , @viirya , too.
Contributor
Author
|
The failed |
cloud-fan
added a commit
that referenced
this pull request
Mar 10, 2023
…ry and CTE ### What changes were proposed in this pull request? This PR fixes a few issues of parameterized query: 1. replace placeholders in CTE/subqueries 2. don't replace placeholders in non-DML commands as it may store the original SQL text with placeholders and we can't resolve it later (e.g. CREATE VIEW). ### Why are the changes needed? make the parameterized query feature complete ### Does this PR introduce _any_ user-facing change? yes, bug fix ### How was this patch tested? new tests Closes #40333 from cloud-fan/parameter. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit a780703) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
This is a bug fix of a new feature in 3.4, so I won't call it a release blocker. I've set the fixed version to 3.4.0, if rc3 passes, I'll change it to 3.4.1. |
Member
|
Seems like the compliation didn't pass. Let me just quickly revert this and reopen. |
Contributor
Author
|
maybe there is a conflict right after my last commit, let me rebase |
viirya
approved these changes
Mar 10, 2023
HyukjinKwon
approved these changes
Mar 10, 2023
Contributor
Author
|
GA passes, let me merge it back. |
cloud-fan
added a commit
that referenced
this pull request
Mar 10, 2023
…ry and CTE This PR fixes a few issues of parameterized query: 1. replace placeholders in CTE/subqueries 2. don't replace placeholders in non-DML commands as it may store the original SQL text with placeholders and we can't resolve it later (e.g. CREATE VIEW). make the parameterized query feature complete yes, bug fix new tests Closes #40333 from cloud-fan/parameter. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit f8966e7) Signed-off-by: Wenchen Fan <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…ry and CTE This PR fixes a few issues of parameterized query: 1. replace placeholders in CTE/subqueries 2. don't replace placeholders in non-DML commands as it may store the original SQL text with placeholders and we can't resolve it later (e.g. CREATE VIEW). make the parameterized query feature complete yes, bug fix new tests Closes apache#40333 from cloud-fan/parameter. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit f8966e7) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a few issues of parameterized query:
Why are the changes needed?
make the parameterized query feature complete
Does this PR introduce any user-facing change?
yes, bug fix
How was this patch tested?
new tests