[SPARK-42710][CONNECT][PYTHON] Rename FrameMap proto to MapPartitions #40329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
Member
Author
zhengruifeng
approved these changes
Mar 8, 2023
HyukjinKwon
reviewed
Mar 8, 2023
connector/connect/common/src/main/protobuf/spark/connect/relations.proto
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Mar 9, 2023
Member
|
@xinrong-meng mind rebasing this? Otherwise should be good to go |
zhengruifeng
pushed a commit
that referenced
this pull request
Mar 9, 2023
### What changes were proposed in this pull request? Rename FrameMap proto to MapPartitions. ### Why are the changes needed? For readability. Frame Map API refers to mapInPandas and mapInArrow, which are equivalent to MapPartitions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #40329 from xinrong-meng/mapInArrow. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 7a67be1) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
|
merged to master/branch-3.4 |
Member
Author
|
Thanks @zhengruifeng ! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Rename FrameMap proto to MapPartitions. ### Why are the changes needed? For readability. Frame Map API refers to mapInPandas and mapInArrow, which are equivalent to MapPartitions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#40329 from xinrong-meng/mapInArrow. Authored-by: Xinrong Meng <xinrong@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 7a67be1) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename FrameMap proto to MapPartitions.
Why are the changes needed?
For readability.
Frame Map API refers to mapInPandas and mapInArrow, which are equivalent to MapPartitions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
SPARK-41661