[SPARK-41775][PYTHON][FOLLOW-UP] Updating error message for training using PyTorch functions #40322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithwik-db
changed the title
HyukjinKwon
approved these changes
Mar 8, 2023
zhengruifeng
approved these changes
Mar 8, 2023
zhengruifeng
pushed a commit
that referenced
this pull request
Mar 8, 2023
…using PyTorch functions ### What changes were proposed in this pull request? I added a better way to show the error instead of having it be confusing for the reader. ### Why are the changes needed? User experience. ### Does this PR introduce _any_ user-facing change? Just the error that will be shown to the user. ### How was this patch tested? Tested it out locally. Closes #40322 from rithwik-db/torch-distributor-error-fix. Authored-by: Rithwik Ediga Lakhamsani <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]> (cherry picked from commit 5db84b5) Signed-off-by: Ruifeng Zheng <[email protected]>
Contributor
|
merged into master/branch-3.4 |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…using PyTorch functions ### What changes were proposed in this pull request? I added a better way to show the error instead of having it be confusing for the reader. ### Why are the changes needed? User experience. ### Does this PR introduce _any_ user-facing change? Just the error that will be shown to the user. ### How was this patch tested? Tested it out locally. Closes apache#40322 from rithwik-db/torch-distributor-error-fix. Authored-by: Rithwik Ediga Lakhamsani <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]> (cherry picked from commit 5db84b5) Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I added a better way to show the error instead of having it be confusing for the reader.
Why are the changes needed?
User experience.
Does this PR introduce any user-facing change?
Just the error that will be shown to the user.
How was this patch tested?
Tested it out locally.