[SPARK-42692][CONNECT] Implement Dataset.toJSON
#40319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
Dataset.toJSON
hvanhovell
reviewed
Mar 7, 2023
|
|
||
| def toJSON: Dataset[String] = { | ||
| throw new UnsupportedOperationException("toJSON is not implemented.") | ||
| sparkSession.newDataset(StringEncoder) { builder => |
Contributor
There was a problem hiding this comment.
Why is this better over project(to_json(col(*))).as(StringEncoder)?
Contributor
Author
There was a problem hiding this comment.
Sorry ... what is project?
Contributor
Author
There was a problem hiding this comment.
Thanks . Sorry I didn't understand what project is before ...
hvanhovell
reviewed
Mar 7, 2023
|
|
||
| test("toJSON") { | ||
| val expected = Array( | ||
| "{\"b\":0.0,\"id\":0,\"d\":\"world\",\"a\":0}", |
Contributor
There was a problem hiding this comment.
Use raw strings here. That is easier to read.
val expected = Array(
"""{"b":0.0,"id":0,"d":"world","a":0}""",
...
)
Contributor
|
LGTM |
hvanhovell
pushed a commit
that referenced
this pull request
Mar 7, 2023
### What changes were proposed in this pull request? This pr aims to implement Dataset.toJSON. ### Why are the changes needed? Add Spark connect jvm client api coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Add new test - Manually checked Scala 2.13 Closes #40319 from LuciferYang/SPARK-42692. Authored-by: yangjie01 <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 51504e4) Signed-off-by: Herman van Hovell <[email protected]>
Contributor
Author
|
Thanks @hvanhovell @amaliujia |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This pr aims to implement Dataset.toJSON. ### Why are the changes needed? Add Spark connect jvm client api coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Add new test - Manually checked Scala 2.13 Closes apache#40319 from LuciferYang/SPARK-42692. Authored-by: yangjie01 <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 51504e4) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to implement Dataset.toJSON.
Why are the changes needed?
Add Spark connect jvm client api coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?