Skip to content

[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime instead of 0 for the duration field #40313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime instead of 0 for the duration field #40313

yaooqinn wants to merge 2 commits into from

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Mar 7, 2023

What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

Why are the changes needed?

Fix REST API OneApplicationResource

Does this PR introduce any user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

How was this patch tested?

locally build and run

[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]

mridulm
mridulm reviewed Mar 7, 2023
View reviewed changes
@yaooqinn
Copy link
Member Author

yaooqinn commented Mar 9, 2023

cc @HyukjinKwon @srowen @dongjoon-hyun ,thanks

@yaooqinn yaooqinn closed this in d3d8fdc Mar 9, 2023
yaooqinn added a commit that referenced this pull request Mar 9, 2023
@yaooqinn
[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime …
afced91 
…instead of 0 for the duration field

### What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

### Why are the changes needed?

Fix REST API OneApplicationResource

### Does this PR introduce _any_ user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

### How was this patch tested?

locally build and run

```json
[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]
```

Closes #40313 from yaooqinn/SPARK-42697.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit d3d8fdc)
Signed-off-by: Kent Yao <[email protected]>
yaooqinn added a commit that referenced this pull request Mar 9, 2023
@yaooqinn
[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime …
cfcd453 
…instead of 0 for the duration field

### What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

### Why are the changes needed?

Fix REST API OneApplicationResource

### Does this PR introduce _any_ user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

### How was this patch tested?

locally build and run

```json
[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]
```

Closes #40313 from yaooqinn/SPARK-42697.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit d3d8fdc)
Signed-off-by: Kent Yao <[email protected]>
yaooqinn added a commit that referenced this pull request Mar 9, 2023
@yaooqinn
[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime …
794d143 
…instead of 0 for the duration field

### What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

### Why are the changes needed?

Fix REST API OneApplicationResource

### Does this PR introduce _any_ user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

### How was this patch tested?

locally build and run

```json
[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]
```

Closes #40313 from yaooqinn/SPARK-42697.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit d3d8fdc)
Signed-off-by: Kent Yao <[email protected]>
@yaooqinn
Copy link
Member Author

yaooqinn commented Mar 9, 2023

thanks @mridulm @srowen, merged to master/3.4/3.3/3.2

@yaooqinn yaooqinn deleted the SPARK-42697 branch March 9, 2023 05:36
dongjoon-hyun
dongjoon-hyun reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, late LGTM. Thank you, @yaooqinn and all.

sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
@yaooqinn @kazuyukitanimura
[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime …
8f9f1e0 
…instead of 0 for the duration field

### What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

### Why are the changes needed?

Fix REST API OneApplicationResource

### Does this PR introduce _any_ user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

### How was this patch tested?

locally build and run

```json
[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]
```

Closes apache#40313 from yaooqinn/SPARK-42697.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit d3d8fdc)
Signed-off-by: Kent Yao <[email protected]>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
@yaooqinn @dongjoon-hyun
[SPARK-42697][WEBUI] Fix /api/v1/applications to return total uptime …
42fc414 
…instead of 0 for the duration field

### What changes were proposed in this pull request?

Fix /api/v1/applications to return total uptime instead of 0 for duration

### Why are the changes needed?

Fix REST API OneApplicationResource

### Does this PR introduce _any_ user-facing change?

yes, /api/v1/applications will return the total uptime instead of 0 for the duration

### How was this patch tested?

locally build and run

```json
[ {
  "id" : "local-1678183638394",
  "name" : "SparkSQL::10.221.102.180",
  "attempts" : [ {
    "startTime" : "2023-03-07T10:07:17.754GMT",
    "endTime" : "1969-12-31T23:59:59.999GMT",
    "lastUpdated" : "2023-03-07T10:07:17.754GMT",
    "duration" : 20317,
    "sparkUser" : "kentyao",
    "completed" : false,
    "appSparkVersion" : "3.5.0-SNAPSHOT",
    "startTimeEpoch" : 1678183637754,
    "endTimeEpoch" : -1,
    "lastUpdatedEpoch" : 1678183637754
  } ]
} ]
```

Closes apache#40313 from yaooqinn/SPARK-42697.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit d3d8fdc)
Signed-off-by: Kent Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen left review comments

@dongjoon-hyun dongjoon-hyun dongjoon-hyun left review comments

@mridulm mridulm mridulm approved these changes

Assignees

No one assigned

Labels

CORE WEB UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yaooqinn @srowen @mridulm @dongjoon-hyun