[SPARK-42684][SQL] v2 catalog should not allow column default value by default #40299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dtenedor
approved these changes
Mar 8, 2023
Contributor
dtenedor
left a comment
dtenedor
left a comment
There was a problem hiding this comment.
This is a good safeguard for correctness.
| ident: Identifier): Unit = { | ||
| if (SQLConf.get.enableDefaultColumns && | ||
| schema.exists(_.metadata.contains(CURRENT_DEFAULT_COLUMN_METADATA_KEY))) { | ||
| if (!catalog.capabilities().contains( |
Contributor
There was a problem hiding this comment.
We can combine with the previous if statement using &&?
Contributor
Author
|
thanks for review, merging to master/3.4! |
cloud-fan
added a commit
that referenced
this pull request
Mar 8, 2023
…y default ### What changes were proposed in this pull request? Following generated columns, column default value should also have a catalog capability and v2 catalogs must explicitly declare SUPPORT_COLUMN_DEFAULT_VALUE to support it. ### Why are the changes needed? column default value needs dedicated handling and if a catalog simply ignores it, then query result can be wrong. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new tests Closes #40299 from cloud-fan/default. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 69dd20b) Signed-off-by: Wenchen Fan <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…y default ### What changes were proposed in this pull request? Following generated columns, column default value should also have a catalog capability and v2 catalogs must explicitly declare SUPPORT_COLUMN_DEFAULT_VALUE to support it. ### Why are the changes needed? column default value needs dedicated handling and if a catalog simply ignores it, then query result can be wrong. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new tests Closes apache#40299 from cloud-fan/default. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 69dd20b) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following generated columns, column default value should also have a catalog capability and v2 catalogs must explicitly declare SUPPORT_COLUMN_DEFAULT_VALUE to support it.
Why are the changes needed?
column default value needs dedicated handling and if a catalog simply ignores it, then query result can be wrong.
Does this PR introduce any user-facing change?
No
How was this patch tested?
new tests