[SPARK-42643][CONNECT][PYTHON] Register Java (aggregate) user-defined functions #40244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
spark.udf.registerJavaFunction
xinrong-meng
changed the title
spark.udf.registerJavaFunctionspark.udf.registerJavaFunction
xinrong-meng
force-pushed
the
registerJava
branch
from
a944368 to
5673a9a
Compare
xinrong-meng
commented
Mar 6, 2023
Member
Author
There was a problem hiding this comment.
JavaUDF has no deterministic field but the server doesn't have logic that relies on that field. So only the comment is changed to minimize changes to proto.
xinrong-meng
force-pushed
the
registerJava
branch
from
98f05d1 to
93728ea
Compare
xinrong-meng
changed the title
spark.udf.registerJavaFunctionspark.udf.registerJavaFunction
Member
Author
xinrong-meng
changed the title
spark.udf.registerJavaFunction
xinrong-meng
changed the title
Member
Author
|
After double thoughts, I add |
Member
|
WDYT @hvanhovell ? |
xinrong-meng
force-pushed
the
registerJava
branch
from
995c287 to
9474361
Compare
HyukjinKwon
approved these changes
Mar 8, 2023
xinrong-meng
added a commit
that referenced
this pull request
Mar 8, 2023
… functions ### What changes were proposed in this pull request? Implement `spark.udf.registerJavaFunction` and `spark.udf.registerJavaUDAF`. A new proto `JavaUDF` is introduced. ### Why are the changes needed? Parity with vanilla PySpark. ### Does this PR introduce _any_ user-facing change? Yes. `spark.udf.registerJavaFunction` and `spark.udf.registerJavaUDAF` are supported now. ### How was this patch tested? Parity unit tests. Closes #40244 from xinrong-meng/registerJava. Authored-by: Xinrong Meng <[email protected]> Signed-off-by: Xinrong Meng <[email protected]> (cherry picked from commit 92aa087) Signed-off-by: Xinrong Meng <[email protected]>
Member
Author
|
Merged to master and branch-3.4, thanks all! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… functions ### What changes were proposed in this pull request? Implement `spark.udf.registerJavaFunction` and `spark.udf.registerJavaUDAF`. A new proto `JavaUDF` is introduced. ### Why are the changes needed? Parity with vanilla PySpark. ### Does this PR introduce _any_ user-facing change? Yes. `spark.udf.registerJavaFunction` and `spark.udf.registerJavaUDAF` are supported now. ### How was this patch tested? Parity unit tests. Closes apache#40244 from xinrong-meng/registerJava. Authored-by: Xinrong Meng <[email protected]> Signed-off-by: Xinrong Meng <[email protected]> (cherry picked from commit 92aa087) Signed-off-by: Xinrong Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
spark.udf.registerJavaFunctionandspark.udf.registerJavaUDAF.A new proto
JavaUDFis introduced.Why are the changes needed?
Parity with vanilla PySpark.
Does this PR introduce any user-facing change?
Yes.
spark.udf.registerJavaFunctionandspark.udf.registerJavaUDAFare supported now.How was this patch tested?
Parity unit tests.
SPARK-41661