Skip to content

[SPARK-41952][SQL] Fix Parquet zstd off-heap memory leak as a workaround for PARQUET-2160 #40091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 4 commits into from
Closed

[SPARK-41952][SQL] Fix Parquet zstd off-heap memory leak as a workaround for PARQUET-2160 #40091

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3c3769
[SPARK-41952] Fix Parquet zstd off-heap memory leak as a workaround f…
pan3793 Feb 20, 2023
1391354
code style
pan3793 Feb 20, 2023
9ee8ba0
code style
pan3793 Feb 20, 2023
d2b84d0
nit
pan3793 Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetCodecFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
* This class implements a codec factory that is used when reading from Parquet. It adds a
* workaround for memory issues encountered when reading from zstd-compressed files. For
* details, see <a href="https://issues.apache.org/jira/browse/PARQUET-2160">PARQUET-2160</a>
*
* TODO: Remove this workaround after upgrading Parquet which include PARQUET-2160.
Copy link
Contributor

@LuciferYang LuciferYang Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be TODO(SPARK-xxx):

*/
public class ParquetCodecFactory extends CodecFactory {
Copy link
Contributor

@LuciferYang LuciferYang Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a TODO to remind us to revert this file when updating Parquet version

Copy link
Member Author

@pan3793 pan3793 Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


Expand Down