Skip to content

Conversation

@bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Feb 18, 2023

What changes were proposed in this pull request?

Upgrade ZooKeeper from 3.6.3 to 3.6.4

Release notes

Why are the changes needed?

ZooKeeper 3.6 is EoL since 30th December, 2022

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

@github-actions github-actions bot added the BUILD label Feb 18, 2023
@bjornjorgensen
Copy link
Contributor Author

@yaooqinn you did the last upgrade on this one in #38733 will you have a look at this one?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR description, does this PR aims to upgrade from one EoL version (3.6.3) to another EoL version (3.6.4), @bjornjorgensen ?

[ZooKeeper 3.6 is EoL since 30th December, 2022(https://zookeeper.apache.org/releases.html)

@bjornjorgensen
Copy link
Contributor Author

@dongjoon-hyun yes, that's right.
I think we can have this small update now to master and branch 3.4. When 3.4 is released, we can try to update to a newer version.

@dongjoon-hyun
Copy link
Member

Got it. Thank you for the clarification. Sounds safe.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Feb 20, 2023

Oh, I missed that you wrote branch-3.4 explicitly. Are you sure, @bjornjorgensen ?

I think we can have this small update now to master and branch 3.4. When 3.4 is released, we can try to update to a newer version.

If you want to claim this PR as a blocker, you need to do that properly. In general, you had better do two things at least.

  • Ping, @xinrong-meng , in order to inform her the existence of the blocker.
  • Update SPARK-42486 properly. Currently, the JIRA Affected Version is quite opposite from your comment (or intention) here.

Screenshot 2023-02-19 at 5 15 05 PM

@bjornjorgensen
Copy link
Contributor Author

I did upgrade the JIRA ticket now to include 3.4.0.
This is not a blocker.
I think this is more a nice too have upgrade for 3.4.0.

@dongjoon-hyun
Copy link
Member

I'm not sure new 3.6.4 Zookeepr is urgent or safe in branch-3.4. According to the Maven Central, 3.6.4 is the least adopted (unverified) release among the recent versions. Do we have a test case to support that we need this?

Screenshot 2023-02-20 at 3 30 59 PM

@HyukjinKwon
Copy link
Member

Let's probably don't add it to branch-3.4 ...

@xinrong-meng
Copy link
Member

xinrong-meng commented Feb 21, 2023

Since branch-3.4 CI is under fix so I may have to re-create the tag later. Please let me know if we shall wait for this PR or not.

@dongjoon-hyun
Copy link
Member

IMO, we don't need to wait for this PR, @xinrong-meng .

@xinrong-meng
Copy link
Member

Thanks @dongjoon-hyun!

@bjornjorgensen
Copy link
Contributor Author

Ok, thank you, @dongjoon-hyun

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jun 2, 2023
@github-actions github-actions bot closed this Jun 3, 2023
@bjornjorgensen bjornjorgensen deleted the ZooKeeper-3.6.4 branch November 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants