[SPARK-39859][SQL] Support v2 DESCRIBE TABLE EXTENDED for columns #40058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Feb 16, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1 from my side.
cc @cloud-fan , @viirya , @sunchao , @parthchandra
viirya
changed the title
viirya
reviewed
Feb 16, 2023
Comment on lines
78
to
82
| if (colStats.get.avgLen().isPresent) { | ||
| rows += toCatalystRow("max_col_len", colStats.get.avgLen().getAsLong.toString) | ||
| } else { | ||
| rows += toCatalystRow("max_col_len", "NULL") | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (colStats.get.avgLen().isPresent) { | |
| rows += toCatalystRow("max_col_len", colStats.get.avgLen().getAsLong.toString) | |
| } else { | |
| rows += toCatalystRow("max_col_len", "NULL") | |
| } | |
| if (colStats.get.maxLen().isPresent) { | |
| rows += toCatalystRow("max_col_len", colStats.get.maxLen().getAsLong.toString) | |
| } else { | |
| rows += toCatalystRow("max_col_len", "NULL") | |
| } |
viirya
reviewed
Feb 16, 2023
| r.table.asReadable.newScanBuilder(CaseInsensitiveStringMap.empty()).build() match { | ||
| case s: SupportsReportStatistics => | ||
| val stats = s.estimateStatistics() | ||
| Some(stats.columnStats().get(FieldReference.column(c.name))) |
Member
There was a problem hiding this comment.
Is columnStats case-sensitive or not?
Contributor
Author
There was a problem hiding this comment.
I think this is controlled by SQLConf.CASE_SENSITIVE
viirya
approved these changes
Feb 16, 2023
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 17, 2023
### What changes were proposed in this pull request? Support v2 DESCRIBE TABLE EXTENDED for columns ### Why are the changes needed? DS v1/v2 command parity ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes #40058 from huaxingao/describe_col. Authored-by: huaxingao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ebab0ef) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.4 for Apache Spark 3.4.0. Thank you, @huaxingao and @viirya . cc @MaxGekk since he filed SPARK-39859 originally. |
Contributor
Author
|
Thanks @dongjoon-hyun @viirya |
cloud-fan
reviewed
Feb 20, 2023
| case c: Attribute => | ||
| DescribeColumnExec(output, c, isExtended) :: Nil | ||
| val colStats = | ||
| r.table.asReadable.newScanBuilder(CaseInsensitiveStringMap.empty()).build() match { |
Contributor
There was a problem hiding this comment.
this may not be very cheap. Shall we only do it if isExtended is true?
Contributor
There was a problem hiding this comment.
and what if the table is not readable (e.g. write-only)? We should not fail but show no column stats.
Contributor
There was a problem hiding this comment.
BTW, I think it's cleaner to pass v2 Table to DescribeColumnExec and move this code block to DescribeColumnExec
Contributor
Author
There was a problem hiding this comment.
@cloud-fan Thanks for your comments. I will have a follow-up to fix this and also move the test to parent suite.
cloud-fan
reviewed
Feb 20, 2023
| } | ||
|
|
||
| // TODO(SPARK-39859): Support v2 `DESCRIBE TABLE EXTENDED` for columns | ||
| test("describe extended (formatted) a column") { |
Contributor
There was a problem hiding this comment.
don't have to be done immediately, but it's better to move this test to the parent suite, to make sure v1 and v2 commands have the same behavior.
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Support v2 DESCRIBE TABLE EXTENDED for columns ### Why are the changes needed? DS v1/v2 command parity ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#40058 from huaxingao/describe_col. Authored-by: huaxingao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ebab0ef) Signed-off-by: Dongjoon Hyun <[email protected]>
MaxGekk
pushed a commit
that referenced
this pull request
Jan 2, 2024
### What changes were proposed in this pull request? Support v2 DESCRIBE TABLE EXTENDED with table stats ### Why are the changes needed? Similar to #40058, make DS v1/v2 command parity, e.g. DESC EXTENDED table | col_name | data_type | comment | |-------------------|---------------------------|------------| | ... | ... | ... | | Statistics | 864 bytes, 2 rows | | | ... | ... | ... | ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add test `describe extended table with stats` ### Was this patch authored or co-authored using generative AI tooling? No Closes #44535 from Zouxxyy/dev/desc-table-stats. Lead-authored-by: zouxxyy <[email protected]> Co-authored-by: Zouxxyy <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support v2 DESCRIBE TABLE EXTENDED for columns
Why are the changes needed?
DS v1/v2 command parity
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT