Skip to content

[SPARK-42219][CORE] Introducing a config to close all active SparkContexts after the Main method has finished #39775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
attilapiros wants to merge 8 commits into from
Closed

[SPARK-42219][CORE] Introducing a config to close all active SparkContexts after the Main method has finished #39775

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3e9b9b
Initial version.
attilapiros Jan 27, 2023
b79e3cf
fix config's version tag
attilapiros Jan 27, 2023
7614a5a
Move config to the k8s module
attilapiros Jan 27, 2023
72ee3cb
reword the config's doc
attilapiros Jan 30, 2023
5d7da38
Merge remote-tracking branch 'parent/master' into SPARK-42219
attilapiros Feb 1, 2023
f6e5d96
Merge remote-tracking branch 'parent/master' into SPARK-42219
attilapiros Feb 19, 2023
ff891aa
Change the default of autoStopActiveSparkContexts to true
attilapiros May 11, 2023
bdc1f38
Merge branch 'apache:master' into SPARK-42219
attilapiros May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,8 +1005,9 @@ private[spark] class SparkSubmit extends Logging {
case t: Throwable =>
throw findCause(t)
} finally {
if (args.master.startsWith("k8s") && !isShell(args.primaryResource) &&
!isSqlShell(args.mainClass) && !isThriftServer(args.mainClass)) {
if (sparkConf.get(AUTO_STOP_ACTIVE_SPARK_CONTEXTS) && args.master.startsWith("k8s") &&
Comment thread
attilapiros marked this conversation as resolved.
Outdated
!isShell(args.primaryResource) && !isSqlShell(args.mainClass) &&
!isThriftServer(args.mainClass)) {
try {
SparkContext.getActive.foreach(_.stop())
} catch {
Expand Down
8 changes: 8 additions & 0 deletions core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,6 +2020,14 @@ package object config {
.toSequence
.createWithDefault(Nil)

private[spark] val AUTO_STOP_ACTIVE_SPARK_CONTEXTS =
ConfigBuilder("spark.kubernetes.submit.autoStopActiveSparkContexts")
Comment thread
attilapiros marked this conversation as resolved.
Outdated
.version("3.4.0")
Comment thread
attilapiros marked this conversation as resolved.
Outdated
.doc("When set to true, on Kubernetes Spark will stop all the active Spark contexts after " +
"the finish of non-shell applications' main method.")
.booleanConf
.createWithDefault(false)

private[spark] val SCHEDULER_ALLOCATION_FILE =
ConfigBuilder("spark.scheduler.allocation.file")
.version("0.8.1")
Expand Down