Skip to content

[SPARK-5168] Make SQLConf a field rather than mixin in SQLContext #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-5168] Make SQLConf a field rather than mixin in SQLContext #3965

wants to merge 4 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jan 9, 2015

This change should be binary and source backward compatible since we didn't change any user facing APIs.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25298 has started for PR 3965 at commit 68d6fa5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25298 has finished for PR 3965 at commit 68d6fa5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 9, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25298/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25332 has started for PR 3965 at commit 608e149.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25332 has finished for PR 3965 at commit 608e149.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 9, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25332/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25344 has started for PR 3965 at commit c1820fc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25344 has finished for PR 3965 at commit c1820fc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 9, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25344/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 10, 2015

Test build #25358 has started for PR 3965 at commit 42411e0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 10, 2015

Test build #25358 has finished for PR 3965 at commit 42411e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 10, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25358/
Test PASSed.

marmbrus
marmbrus reviewed Jan 10, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala
Copy link
Contributor

@marmbrus marmbrus Jan 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nit, but you probably don't need the self anymore.

Copy link
Contributor Author

@rxin rxin Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more future proof and slightly more clear? Since it is a small addition (just "self.").

@marmbrus
Copy link
Contributor

marmbrus commented Jan 10, 2015

Hey, sorry this conflicts now. I really like the change though!

@marmbrus marmbrus mentioned this pull request Jan 10, 2015
Closed
@rxin rxin force-pushed the SPARK-5168-sqlconf branch from 42411e0 to 42eec09 Compare January 11, 2015 08:35
@rxin
Copy link
Contributor Author

rxin commented Jan 11, 2015

I rebased - should merge cleanly now.

@SparkQA
Copy link

SparkQA commented Jan 11, 2015

Test build #25375 has started for PR 3965 at commit 42eec09.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 11, 2015

Test build #25375 has finished for PR 3965 at commit 42eec09.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25375/
Test PASSed.

@asfgit asfgit closed this in 14e3f11 Jan 13, 2015
@rxin rxin mentioned this pull request Jan 16, 2015
Closed
asfgit pushed a commit that referenced this pull request Jan 17, 2015
@rxin
[SPARK-5193][SQL] Remove Spark SQL Java-specific API.
61b427d 
After the following patches, the main (Scala) API is now usable for Java users directly.

#4056
#4054
#4049
#4030
#3965
#3958

Author: Reynold Xin <[email protected]>

Closes #4065 from rxin/sql-java-api and squashes the following commits:

b1fd860 [Reynold Xin] Fix Mima
6d86578 [Reynold Xin] Ok one more attempt in fixing Python...
e8f1455 [Reynold Xin] Fix Python again...
3e53f91 [Reynold Xin] Fixed Python.
83735da [Reynold Xin] Fix BigDecimal test.
e9f1de3 [Reynold Xin] Use scala BigDecimal.
500d2c4 [Reynold Xin] Fix Decimal.
ba3bfa2 [Reynold Xin] Updated javadoc for RowFactory.
c4ae1c5 [Reynold Xin] [SPARK-5193][SQL] Remove Spark SQL Java-specific API.
andmarios pushed a commit to andmarios/spark-examples that referenced this pull request Mar 20, 2015
@rxin
[SPARK-5193][SQL] Remove Spark SQL Java-specific API.
3364cc8 
After the following patches, the main (Scala) API is now usable for Java users directly.

apache/spark#4056
apache/spark#4054
apache/spark#4049
apache/spark#4030
apache/spark#3965
apache/spark#3958

Author: Reynold Xin <[email protected]>

Closes #4065 from rxin/sql-java-api and squashes the following commits:

b1fd860 [Reynold Xin] Fix Mima
6d86578 [Reynold Xin] Ok one more attempt in fixing Python...
e8f1455 [Reynold Xin] Fix Python again...
3e53f91 [Reynold Xin] Fixed Python.
83735da [Reynold Xin] Fix BigDecimal test.
e9f1de3 [Reynold Xin] Use scala BigDecimal.
500d2c4 [Reynold Xin] Fix Decimal.
ba3bfa2 [Reynold Xin] Updated javadoc for RowFactory.
c4ae1c5 [Reynold Xin] [SPARK-5193][SQL] Remove Spark SQL Java-specific API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @SparkQA @AmplabJenkins @marmbrus