[SPARK-42074][SQL] Enable KryoSerializer in TPCDSQueryBenchmark to enforce SQL class registration
#39584
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
KryoSerializer in TPCDSQueryBenchmark to enforce SQL class registration
…force SQL class registration
Member
Author
|
Could you review this please, @viirya ? |
dongjoon-hyun
commented
Jan 15, 2023
| .set("spark.sql.autoBroadcastJoinThreshold", (20 * 1024 * 1024).toString) | ||
| .set("spark.sql.crossJoin.enabled", "true") | ||
| .set("spark.serializer", "org.apache.spark.serializer.KryoSerializer") | ||
| .set("spark.kryo.registrationRequired", "true") |
Member
Author
There was a problem hiding this comment.
This will cause failure in TPCDS SF=1 GitHub Action job if some PR missed the class registration.
viirya
approved these changes
Jan 16, 2023
Member
Author
|
Thank you, @viirya ! |
Member
Author
|
Merged to master for Apache Spark 3.4.0. |
Contributor
|
Late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
KryoSerializerinTPCDSQueryBenchmarkto enforce build-in SQL class registration.Why are the changes needed?
GitHub Action CI will ensure that all new SQL related classes to be registered .
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs. I also manually tested like the following.