Skip to content

[SPARK-42073][CONNECT][PYTHON][TESTS] Enable tests in common/test_parity_serde, common/test_parity_types #39583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
techaddict wants to merge 1 commit into from
Closed

[SPARK-42073][CONNECT][PYTHON][TESTS] Enable tests in common/test_parity_serde, common/test_parity_types #39583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions python/pyspark/sql/tests/connect/test_parity_serde.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ def test_int_array_serialization(self):
def test_serialize_nested_array_and_map(self):
super().test_serialize_nested_array_and_map()

@unittest.skip("Spark Connect does not support RDD but the tests depend on them.")
def test_struct_in_map(self):
super().test_struct_in_map()


if __name__ == "__main__":
import unittest
Expand Down
8 changes: 0 additions & 8 deletions python/pyspark/sql/tests/connect/test_parity_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ def test_cast_to_udt_with_udt(self):
def test_complex_nested_udt_in_df(self):
super().test_complex_nested_udt_in_df()

@unittest.skip("Spark Connect does not support RDD but the tests depend on them.")
def test_convert_row_to_dict(self):
super().test_convert_row_to_dict()

# TODO(SPARK-42020): createDataFrame with UDT
@unittest.skip("Fails in Spark Connect, should enable.")
def test_create_dataframe_from_objects(self):
Expand Down Expand Up @@ -137,10 +133,6 @@ def test_infer_schema_upcast_int_to_string(self):
def test_infer_schema_with_udt(self):
super().test_infer_schema_with_udt()

@unittest.skip("Spark Connect does not support RDD but the tests depend on them.")
def test_metadata_null(self):
super().test_metadata_null()

# TODO(SPARK-41834): Implement SparkSession.conf
@unittest.skip("Fails in Spark Connect, should enable.")
def test_negative_decimal(self):
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/sql/tests/test_serde.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_select_null_literal(self):

def test_struct_in_map(self):
d = [Row(m={Row(i=1): Row(s="")})]
df = self.sc.parallelize(d).toDF()
df = self.spark.createDataFrame(d)
k, v = list(df.head().m.items())[0]
self.assertEqual(1, k.i)
self.assertEqual("", v.s)
Expand Down
5 changes: 2 additions & 3 deletions python/pyspark/sql/tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ def test_apply_schema(self):
def test_convert_row_to_dict(self):
row = Row(l=[Row(a=1, b="s")], d={"key": Row(c=1.0, d="2")})
self.assertEqual(1, row.asDict()["l"][0].a)
df = self.sc.parallelize([row]).toDF()
df = self.spark.createDataFrame([row])

with self.tempView("test"):
df.createOrReplaceTempView("test")
Expand Down Expand Up @@ -788,8 +788,7 @@ def test_metadata_null(self):
StructField("f2", StringType(), True, {"a": None}),
]
)
rdd = self.sc.parallelize([["a", "b"], ["c", "d"]])
self.spark.createDataFrame(rdd, schema)
self.spark.createDataFrame([["a", "b"], ["c", "d"]], schema)

def test_access_nested_types(self):
df = self.spark.createDataFrame([Row(l=[1], r=Row(a=1, b="b"), d={"k": "v"})])
Expand Down