[SPARK-41903][CONNECT][PYTHON] Literal should support 1-dim ndarray
#39570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Jan 14, 2023
| if _from_numpy_type(col.dtype) is None: | ||
| raise TypeError("The type of array scalar '%s' is not supported" % (col.dtype)) | ||
|
|
||
| # NumpyArrayConverter for Py4J can not support ndarray with int8 values. |
Contributor
Author
There was a problem hiding this comment.
HyukjinKwon
approved these changes
Jan 15, 2023
Member
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Literalshould support 1-dim ndarrayWhy are the changes needed?
parity
Does this PR introduce any user-facing change?
yes
How was this patch tested?
enabled UT