Skip to content

[SPARK-41814][SPARK-41851][SPARK-41852][FOLLOW-UP] Reeanble skipped doctests #39363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-41814][SPARK-41851][SPARK-41852][FOLLOW-UP] Reeanble skipped doctests #39363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/pyspark/sql/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ def __ne__( # type: ignore[override]
__gt__ = _bin_op("gt")

# TODO(SPARK-41812): DataFrame.join: ambiguous column
# TODO(SPARK-41814): Column.eqNullSafe fails on NaN comparison
_eqNullSafe_doc = """
Equality test that is safe for null values.

Expand Down Expand Up @@ -332,7 +331,7 @@ def __ne__( # type: ignore[override]
... df2['value'].eqNullSafe(None),
... df2['value'].eqNullSafe(float('NaN')),
... df2['value'].eqNullSafe(42.0)
... ).show() # doctest: +SKIP
... ).show()
+----------------+---------------+----------------+
|(value <=> NULL)|(value <=> NaN)|(value <=> 42.0)|
+----------------+---------------+----------------+
Expand Down
6 changes: 0 additions & 6 deletions python/pyspark/sql/connect/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2447,12 +2447,6 @@ def _test() -> None:
# TODO(SPARK-41850): fix isnan
del pyspark.sql.connect.functions.isnan.__doc__

# TODO(SPARK-41851): fix nanvl
del pyspark.sql.connect.functions.nanvl.__doc__

# TODO(SPARK-41852): fix pmod
del pyspark.sql.connect.functions.pmod.__doc__

# Creates a remote Spark session.
os.environ["SPARK_REMOTE"] = "sc://localhost"
globs["spark"] = PySparkSession.builder.remote("sc://localhost").getOrCreate()
Expand Down