[SPARK-41807][CORE] Remove non-existent error class: UNSUPPORTED_FEATURE.DISTRIBUTE_BY#39335
Closed
panbingkun wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41807][CORE] Remove non-existent error class: UNSUPPORTED_FEATURE.DISTRIBUTE_BY#39335panbingkun wants to merge 1 commit intoapache:masterfrom
panbingkun wants to merge 1 commit intoapache:masterfrom
Conversation
panbingkun
changed the title
MaxGekk
reviewed
Jan 2, 2023
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
This error class was added by @srielau in the PR #36307 but it wasn't used even in the PR. Are there any reasons to still keep the error class? cc @cloud-fan
|
Can one of the admins verify this patch? |
MaxGekk
approved these changes
Jan 2, 2023
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@panbingkun I'm ok w/ removing the error class. Please, remove [WIP] if it is ready to merge.
panbingkun
changed the title
Contributor
Author
Ok, done. |
MaxGekk
changed the title
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to remove non-existent error class: UNSUPPORTED_FEATURE.DISTRIBUTE_BY.
Why are the changes needed?
When I want to add UT for error class: UNSUPPORTED_FEATURE.DISTRIBUTE_BY, I found it no longer in use.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.