[SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime #39247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc. @rxin @cloud-fan |
Contributor
Author
|
cc. @viirya as well |
cloud-fan
approved these changes
Dec 28, 2022
…ResolveWindowTime
HeartSaVioR
force-pushed
the
SPARK-41733
branch
from
047be26 to
91d4d9f
Compare
Contributor
Author
|
The change is only to rebase the fix due to the conflict from #39245. I'm going to merge once the CI passes. |
viirya
approved these changes
Dec 28, 2022
Contributor
Author
|
https://github.com/HeartSaVioR/spark/runs/10328690654 |
Contributor
Author
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to apply tree-pattern based pruning for the rule ResolveWindowTime, to minimize the evaluation of rule with WindowTime node.
Why are the changes needed?
The rule ResolveWindowTime is unnecessarily evaluated multiple times without proper pruning.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. New test case is added to cover SQL usage for
window_time.