[MINOR][TEST][SQL] Add a CTE subquery scope test case. #39189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Dec 23, 2022
HyukjinKwon
approved these changes
Dec 23, 2022
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM but shall we file a JIRA?
rxin
changed the title
rxin
added a commit
that referenced
this pull request
Dec 23, 2022
### What changes were proposed in this pull request? I noticed we were missing a test case for this in SQL tests, so I added one. ### Why are the changes needed? To ensure we scope CTEs properly in subqueries. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This is a test case change. Closes #39189 from rxin/cte_test. Authored-by: Reynold Xin <[email protected]> Signed-off-by: Reynold Xin <[email protected]> (cherry picked from commit 24edf8e) Signed-off-by: Reynold Xin <[email protected]>
Contributor
|
@rxin @cloud-fan @HyukjinKwon |
Contributor
|
I have reverted it from 3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I noticed we were missing a test case for this in SQL tests, so I added one.
Why are the changes needed?
To ensure we scope CTEs properly in subqueries.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a test case change.