Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 16, 2022

What changes were proposed in this pull request?

This PR proposes to set parallelism as 1 for coverage report in Spark Connect. Currently, the coverage report consistently fails for Spark Connect, see https://github.com/apache/spark/actions/runs/3663716955/jobs/6193686439

Why are the changes needed?

To make Spark Connect build working (Spark Connect requires 1 parallelism). Note that this is consistent with our PR builder, see

./dev/run-tests --parallelism 1 --modules "$MODULES_TO_TEST"

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Will monitor the jobs and https://app.codecov.io/gh/apache/spark after merging this.

@github-actions github-actions bot added the BUILD label Dec 16, 2022
@HyukjinKwon
Copy link
Member Author

cc @zhengruifeng @amaliujia @grundprinzip FYI

Copy link
Contributor

@zhengruifeng zhengruifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Copy link
Contributor

@amaliujia amaliujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks for catching this!

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@dongjoon-hyun
Copy link
Member

Thank you, @HyukjinKwon and all. Let's merge this and monitor.
Merged to master.

@HyukjinKwon
Copy link
Member Author

Thank you all!

@HyukjinKwon HyukjinKwon deleted the SPARK-41542 branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants