[SPARK-41410][K8S][FOLLOWUP] Skip splitSlots and requestNewExecutors in case of 0 snapshot#39079
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-41410
Closed
[SPARK-41410][K8S][FOLLOWUP] Skip splitSlots and requestNewExecutors in case of 0 snapshot#39079dongjoon-hyun wants to merge 2 commits intoapache:masterfrom dongjoon-hyun:SPARK-41410
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-41410
Conversation
…in case of 0 snapshot
dongjoon-hyun
commented
Dec 15, 2022
| applicationId: String, | ||
| schedulerBackend: KubernetesClusterSchedulerBackend, | ||
| snapshots: Seq[ExecutorPodsSnapshot]): Unit = { | ||
| logDebug(s"Received ${snapshots.size} snapshots") |
Member
Author
There was a problem hiding this comment.
I added this as DEBUG level because Received 0 snapshots is too verbose.
viirya
reviewed
Dec 15, 2022
Comment on lines
356
to
+358
| val remainingSlotFromPendingPods = maxPendingPods - totalNotRunningPodCount | ||
| if (remainingSlotFromPendingPods > 0 && podsToAllocateWithRpId.size > 0) { | ||
| if (remainingSlotFromPendingPods > 0 && podsToAllocateWithRpId.size > 0 && | ||
| !(snapshots.isEmpty && podAllocOnPVC && maxPVCs <= PVC_COUNTER.get())) { |
Member
There was a problem hiding this comment.
This condition is getting complicated now. Can we add a comment on it?
viirya
approved these changes
Dec 15, 2022
Member
Author
|
I added comments, @viirya . Since that's comment only change, I'll merge this. |
Member
|
Agreed. Thank you @dongjoon-hyun ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up to skip allocation code block (
splitSlotsandrequestNewExecutors) completely when the notified snapshots are an empty array.Why are the changes needed?
When there is no change from K8s control plane side, the notified snapshot is empty like the following. In that case, we still need to do executor clean up, but we don't need to try to create a new executor if we are waiting for new PVCs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.