Skip to content

[MINOR][PS] Workaround to remove several ignores #39075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[MINOR][PS] Workaround to remove several ignores #39075

HyukjinKwon wants to merge 1 commit into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 15, 2022 •
edited
Loading

What changes were proposed in this pull request?

This PR workaround several ignores in MyPy check

Why are the changes needed?

To make MyPy happy.

In addition, It fails (in my local) although I use the exactly same MyPy version.

annotations failed mypy checks:
python/pyspark/pandas/frame.py:6371: error: unused "type: ignore" comment
python/pyspark/pandas/frame.py:6428: error: unused "type: ignore" comment
python/pyspark/pandas/frame.py:6430: error: unused "type: ignore" comment
python/pyspark/pandas/resample.py:104: error: unused "type: ignore" comment
python/pyspark/pandas/resample.py:137: error: unused "type: ignore" comment
Found 5 errors in 2 files (checked 375 source files)

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually tested via ./dev/lint-python in my local.

@HyukjinKwon HyukjinKwon changed the title [MINOR][PYTHON] Remove unused ignores [MINOR][PS] Remove unused ignores Dec 15, 2022
@HyukjinKwon HyukjinKwon marked this pull request as draft December 15, 2022 13:39
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 15, 2022

Let me make some changes to make it pass fine.

@HyukjinKwon HyukjinKwon changed the title [MINOR][PS] Remove unused ignores [MINOR][PS] Workaround to remove several ignores Dec 16, 2022
@HyukjinKwon HyukjinKwon marked this pull request as ready for review December 16, 2022 00:33
dongjoon-hyun
dongjoon-hyun approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon HyukjinKwon force-pushed the remove-unused-ignores branch from 2801962 to 6d0b13b Compare December 16, 2022 01:00
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 16, 2022

Merged to master.

@HyukjinKwon HyukjinKwon deleted the remove-unused-ignores branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

CORE PANDAS API ON SPARK PYTHON

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HyukjinKwon @dongjoon-hyun