[SPARK-39601][YARN][FOLLOWUP] YarnClusterSchedulerBackend should call super.stop() #39053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgravescs
approved these changes
Dec 13, 2022
Contributor
tgravescs
left a comment
tgravescs
left a comment
There was a problem hiding this comment.
thanks for catching this
dongjoon-hyun
approved these changes
Dec 13, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pan3793 and @tgravescs .
Merged to mastser for Apache Spark 3.4.0.
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
… super.stop() ### What changes were proposed in this pull request? This is a followup of apache#38622, I just notice that the `YarnClusterSchedulerBackend#stop` missed calling `super.stop()`. ### Why are the changes needed? Followup previous change, otherwise Spark may not shutdown properly on Yarn cluster mode. ### Does this PR introduce _any_ user-facing change? No, unreleased change. ### How was this patch tested? Existing UT. Closes apache#39053 from pan3793/SPARK-39601-followup. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #38622, I just notice that the
YarnClusterSchedulerBackend#stopmissed callingsuper.stop().Why are the changes needed?
Followup previous change, otherwise Spark may not shutdown properly on Yarn cluster mode.
Does this PR introduce any user-facing change?
No, unreleased change.
How was this patch tested?
Existing UT.